Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Korean translation #214

Merged
merged 7 commits into from Jul 19, 2023
Merged

Added Korean translation #214

merged 7 commits into from Jul 19, 2023

Conversation

KANGPUNGYUN
Copy link
Contributor

@KANGPUNGYUN KANGPUNGYUN commented Jul 5, 2023 •
edited

Description

I translated Euclidean algorithm and Magic square explanation into Korean. And I added missing value in magic_square.md.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing checks pass.
  • No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
  • If it's a new explanation, it contains solid, understandable, and accessible information.
  • I have read the whole contributing guidelines and agree to the Code of Conduct.

appgurueu
appgurueu approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine (again only roughly compared using Google Translate).

Perhaps you should propagate the fix in the english original file (missing number in magic square) to all translations.

@KANGPUNGYUN
Copy link
Contributor Author

KANGPUNGYUN commented Jul 6, 2023 •
edited

You're right. Thanks! I'll fix it right away :)

@KANGPUNGYUN
Copy link
Contributor Author

KANGPUNGYUN commented Jul 6, 2023 •
edited

No file written in other languages.

appgurueu
appgurueu previously approved these changes Jul 6, 2023
View reviewed changes
Panquesito7
Panquesito7 requested changes Jul 6, 2023
View reviewed changes
ko/기초 수학/마방진.md Outdated Show resolved Hide resolved
@KANGPUNGYUN
Update 마방진.md
4cc5444 
edited link to the Algorithm link
@KANGPUNGYUN
Update 유클리드 알고리즘.md
34ad478 
added Algorithm link for implementation.
Panquesito7
Panquesito7 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit 1dc534e into TheAlgorithms:master Jul 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@madhavgaba madhavgaba madhavgaba approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@vbrazo vbrazo Awaiting requested review from vbrazo vbrazo is a code owner

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KANGPUNGYUN @madhavgaba @appgurueu @Panquesito7