feat: Modify search/text_search.cpp #1662

anuran-roy · 2021-10-03T21:11:40Z

Description of Change

Modified text_search.cpp to include case-insensitive search. Also added test function to check for custom function called lower()

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:

anuran-roy · 2021-10-03T21:20:29Z

@Panquesito7 I made a new PR as you suggested. For the blockchain code, I'll soon add it after sufficient changes. Can you please review this? 😃

Panquesito7

Great work! 😄

search/text_search.cpp

Panquesito7 · 2021-10-04T00:29:28Z

search/text_search.cpp

@@ -12,7 +13,31 @@

 /** Main function
 */
+
+std::string lower(std::string word) {  // convert a C++ string to lowercase


Still missing proper documentation (check the typical structure of a program as a reference).

anuran-roy · 2021-10-05T07:52:20Z

@siriak can you please see it? 😅 I guess @Panquesito7 is a bit occupied with some important work...

siriak · 2021-10-05T10:56:07Z

@Panquesito7 needs to review it before merging anyway

Panquesito7

Almost there! 😄

search/text_search.cpp

anuran-roy · 2021-10-06T17:23:57Z

@Panquesito7 I'm done with the required changes 😃

Panquesito7 · 2021-10-06T17:43:11Z

search/text_search.cpp

 /** Main function
 */


It's just to accept this suggestion, and you're done! 😄

Suggested change

/** Main function

*/

/**

* @brief Main function

* @returns 0 on exit

*/

Yeah sure! 😄

Panquesito7

Amazing work! 🚀 Thank you for your contribution! We hope you keep contributing. 😄👍🎉

anuran-roy · 2021-10-06T19:08:09Z

Thank you so much for helping me out throughout the process @Panquesito7 😄 I'll contribute more!

ayaankhan98 · 2021-10-08T17:40:15Z

.gitignore

@@ -34,4 +34,4 @@ a.out
 *.out
 *.app

-build/
+build/


undo this change

Isn't this same? I don't get what's different here 😅

.vscode/settings.json

probability/windowed_median.cpp

…Plus-Plus into modify_text_search

anuran-roy · 2021-10-14T06:49:48Z

@Panquesito7 @ayaankhan98 Uhh... Anything that I should do to make this branch good to merge?

anuran-roy added 2 commits October 4, 2021 01:59

Modified search/text_search.cpp

08c1b69

Added tests

29013b2

Panquesito7 requested changes Oct 3, 2021

View reviewed changes

search/text_search.cpp Show resolved Hide resolved

search/text_search.cpp Outdated Show resolved Hide resolved

search/text_search.cpp Outdated Show resolved Hide resolved

Panquesito7 added enhancement New feature or request requested changes changes required labels Oct 3, 2021

Panquesito7 changed the title ~~Modify search/text_search.cpp~~ feat: Modify search/text_search.cpp Oct 3, 2021

anuran-roy added 3 commits October 4, 2021 03:12

Added a few test cases

b86059b

Added a few more test cases and documentation

db6d253

Minor fix

f108dbc

anuran-roy requested a review from Panquesito7 October 3, 2021 21:52

Panquesito7 requested changes Oct 4, 2021

View reviewed changes

anuran-roy added 2 commits October 4, 2021 09:32

Minor fixes

b5f6af4

Minor fixes

6e6e265

anuran-roy requested a review from Panquesito7 October 4, 2021 04:39

Panquesito7 reviewed Oct 6, 2021

View reviewed changes

search/text_search.cpp Outdated Show resolved Hide resolved

search/text_search.cpp Show resolved Hide resolved

Minor output fixes

a44570b

Panquesito7 reviewed Oct 6, 2021

View reviewed changes

search/text_search.cpp Outdated Show resolved Hide resolved

anuran-roy requested a review from Panquesito7 October 6, 2021 17:23

Minor output fixes

bd4bf94

Panquesito7 reviewed Oct 6, 2021

View reviewed changes

Minor readability fixes

0959929

Panquesito7 previously approved these changes Oct 6, 2021

View reviewed changes

Panquesito7 added approved Approved; waiting for merge Improvement improvement in previously written codes and removed enhancement New feature or request requested changes changes required labels Oct 6, 2021

Panquesito7 requested review from aminoxix, mishraabhinn and ayaankhan98 October 6, 2021 18:24

anuran-roy and others added 2 commits October 7, 2021 09:31

Merge branch 'TheAlgorithms:master' into modify_text_search

a01765a

clang-format and clang-tidy fixes for a01765a

0f2606f

github-actions bot dismissed Panquesito7’s stale review via 0f2606f October 7, 2021 04:02

anuran-roy requested a review from Panquesito7 October 7, 2021 13:50

ayaankhan98 reviewed Oct 8, 2021

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

ayaankhan98 reviewed Oct 8, 2021

View reviewed changes

probability/windowed_median.cpp Show resolved Hide resolved

anuran-roy added 2 commits October 9, 2021 20:24

Restored original settings

e5f72c9

Merge branch 'modify_text_search' of https://github.com/anuran-roy/C-…

0331b38

…Plus-Plus into modify_text_search

anuran-roy requested review from siriak and ayaankhan98 October 9, 2021 14:57

Merge branch 'master' into modify_text_search

6a8f3a4

Panquesito7 previously approved these changes Oct 14, 2021

View reviewed changes

clang-format and clang-tidy fixes for 6a8f3a4

b8f40a2

github-actions bot dismissed Panquesito7’s stale review via b8f40a2 October 14, 2021 18:28

Panquesito7 approved these changes Oct 14, 2021

View reviewed changes

Panquesito7 merged commit 85721be into TheAlgorithms:master Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Modify search/text_search.cpp #1662

feat: Modify search/text_search.cpp #1662

anuran-roy commented Oct 3, 2021 •

edited by gitpod-io bot

Loading

anuran-roy commented Oct 3, 2021

Panquesito7 left a comment

Panquesito7 Oct 4, 2021

anuran-roy commented Oct 5, 2021

siriak commented Oct 5, 2021

Panquesito7 left a comment

anuran-roy commented Oct 6, 2021

Panquesito7 Oct 6, 2021 •

edited

Loading

anuran-roy Oct 6, 2021

anuran-roy Oct 6, 2021

Panquesito7 left a comment

anuran-roy commented Oct 6, 2021

ayaankhan98 Oct 8, 2021

anuran-roy Oct 9, 2021

anuran-roy commented Oct 14, 2021

-/** Main function
- */
+/**
+ * @brief Main function
+ * @returns 0 on exit
+ */

@@ @@ -34,4 +34,4 @@ a.out @@
               *.out
               *.app
-              build/
+              build/

feat: Modify search/text_search.cpp #1662

feat: Modify search/text_search.cpp #1662

Conversation

anuran-roy commented Oct 3, 2021 • edited by gitpod-io bot Loading

Description of Change

Checklist

anuran-roy commented Oct 3, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

Panquesito7 Oct 4, 2021

Choose a reason for hiding this comment

anuran-roy commented Oct 5, 2021

siriak commented Oct 5, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

anuran-roy commented Oct 6, 2021

Panquesito7 Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

anuran-roy Oct 6, 2021

Choose a reason for hiding this comment

anuran-roy Oct 6, 2021

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

anuran-roy commented Oct 6, 2021

ayaankhan98 Oct 8, 2021

Choose a reason for hiding this comment

anuran-roy Oct 9, 2021

Choose a reason for hiding this comment

anuran-roy commented Oct 14, 2021

anuran-roy commented Oct 3, 2021 •

edited by gitpod-io bot

Loading

Panquesito7 Oct 6, 2021 •

edited

Loading