Fix undefined_operator in fermats_little_theorem.dart #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issue TheAlgorithms#86 added test cases @cclauss @Parowicz @StepfenShawn
cclauss
changed the title
cclauss
suggested changes
Oct 24, 2020
maths/fermats_little_theorem.dart
Outdated
| @@ -21,12 +19,22 @@ void main() { | |||
| // a prime number | |||
| int p = 701; | |||
|
|
|||
| double a = 1000000000; | |||
There was a problem hiding this comment.
Removing support for floating point numbers seems like a step too far. Is there a way to keep supporting floating point numbers? Tests should cover positive numbers, negative numbers, and zero as well as floating point numbers if we keep supporting them.
| int b = 10; | ||
|
|
||
| // using binary exponentiation function, O(log(p)): | ||
| print((a / b) % p == (a * binary_exponentiation(b, p - 2, p)) % p); |
There was a problem hiding this comment.
Why remove this? When the visitor runs this program then nothing visible will happen. We are writing these programs primarily for readers to understand and secondarily for computers to test.
| // using Python operators: | ||
| print((a / b) % p == (a * b ^ (p - 2)) % p); |
Added the suggested changes Added print statements Added support for double
fixed dart format issues
|
Tests should cover positive numbers, negative numbers, and zero as well as floating-point numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
added test cases
@cclauss @Parowicz @StepfenShawn
Welcome to Dart community
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.