Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed double linked list and create test for it #272 and fixed contributing.md #313

Merged
merged 6 commits into from Aug 19, 2021

Conversation

Miraddo
Copy link
Contributor

@Miraddo Miraddo commented Jul 13, 2021

  • As we know in the double-linked list, we should have the Next and the Prevent address in each node. In the Test AddAtBeg, I wasn't able to switch between next and prev so, I fixed that part, and now I guess everything Is fine.

For more clear staff, look at this example :

It was like :
first : &{1 nil nil}
second : &{2 address nil}
third : &{3 address nil}

and now it looks like this:

first : &{1 nil address}
second : &{2 address address}
third : &{3 address nil}

  • I updated pull request file inside .github folder
  • I updated contributing.md based on Cpp Contributing File
  • I changed all files and folders names based on contributing guidelines

@lgtm-com
Copy link

lgtm-com bot commented Jul 14, 2021

This pull request introduces 1 alert and fixes 1 when merging 3eb77fe into 0a282fa - view on LGTM.com

new alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@Miraddo Miraddo changed the title fixed double linked list and create test for it fixed double linked list and create test for it and fixed contributing.md Jul 14, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 14, 2021

This pull request introduces 1 alert and fixes 1 when merging 48e0ccb into 0a282fa - view on LGTM.com

new alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@cclauss
Copy link
Member

cclauss commented Jul 14, 2021

Files changed 109 seems a bit high. Can you please visit https://github.com/Miraddo/Go and click on Fetch upstream (that should be just below the green Code button). Thanks.

@Miraddo
Copy link
Contributor Author

Miraddo commented Jul 14, 2021

Files changed 109 seems a bit high. Can you please visit https://github.com/Miraddo/Go and click on Fetch upstream (that should be just below the green Code button). Thanks.

@cclauss , thank you for your reviewing, It seems that part is disable for me "This branch is not behind the upstream"
image

@cclauss
Copy link
Member

cclauss commented Jul 14, 2021

Did you really modify 109 files?

@Miraddo
Copy link
Contributor Author

Miraddo commented Jul 14, 2021

Did you really modify 109 files?

Yes, because we didn't have a "Contribute Guideline," and every developer put their own style on the file's name. Some people created files with PascalCase, camelCase, or they're just put names without any standard.

So to have more clear and readable file names, after fixed contributing guidelines markdown file, I decided to fix them as snake_case style for both files and folders.

I didn't change codes except for one line in the genetic algorithm file. golangci-lint shows an error, so I found the problem, and you can see my last commit. I fixed it.

For sure, I should mention package names changed too.

@Miraddo Miraddo changed the title fixed double linked list and create test for it and fixed contributing.md fixed double linked list and create test for it (#272) and fixed contributing.md Jul 18, 2021
@Miraddo Miraddo changed the title fixed double linked list and create test for it (#272) and fixed contributing.md fixed double linked list and create test for it #272 and fixed contributing.md Jul 18, 2021
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 6345537 into TheAlgorithms:master Aug 19, 2021
@Miraddo Miraddo mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants