New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed double linked list and create test for it #272 and fixed contributing.md #313
Conversation
This pull request introduces 1 alert and fixes 1 when merging 3eb77fe into 0a282fa - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 1 when merging 48e0ccb into 0a282fa - view on LGTM.com new alerts:
fixed alerts:
|
|
@cclauss , thank you for your reviewing, It seems that part is disable for me "This branch is not behind the upstream" |
Did you really modify 109 files? |
Yes, because we didn't have a "Contribute Guideline," and every developer put their own style on the file's name. Some people created files with PascalCase, camelCase, or they're just put names without any standard. So to have more clear and readable file names, after fixed contributing guidelines markdown file, I decided to fix them as snake_case style for both files and folders. I didn't change codes except for one line in the For sure, I should mention package names changed too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
For more clear staff, look at this example :
It was like :
first :
&{1 nil nil}
second :
&{2 address nil}
third :
&{3 address nil}
and now it looks like this:
first :
&{1 nil address}
second :
&{2 address address}
third :
&{3 address nil}