Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace List in BFS with Queue #3231

Merged
merged 4 commits into from Aug 28, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -2,10 +2,11 @@

import com.thealgorithms.searches.DepthFirstSearch.Node;

import java.util.ArrayList;
import java.util.ArrayDeque;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.Queue;

/**
* @author: caos321
Expand All @@ -18,18 +19,18 @@ public static Optional<Node> search(final Node node, final String name) {
return Optional.of(node);
}

List<Node> queue = new ArrayList<>(node.getSubNodes());
Queue<Node> queue = new ArrayDeque<>(node.getSubNodes());

while (!queue.isEmpty()) {
final Node current = queue.get(0);
final Node current = queue.poll();

if (current.getName().equals(name)) {
return Optional.of(current);
}

queue.addAll(current.getSubNodes());

queue.remove(0);
queue.remove();
}

return Optional.empty();
Expand Down