Adds option to configure video interpolation method #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make this an option in SettingsClass and set the default to full linear? Maybe in the Video section? |
OmniBlade
force-pushed
the
feature/interpolate
branch
from
5ca1f10
to
6de609a
Compare
OmniBlade
changed the title
|
Yes I can. |
OmniBlade
force-pushed
the
feature/interpolate
branch
3 times, most recently
from
d85ea51
to
8f1fe66
Compare
hifi
requested changes
Feb 11, 2021
redalert/mapsel.cpp
Outdated
| @@ -154,17 +154,15 @@ char const* Map_Selection(void) | |||
| Animate_Frame(anim, *pseudoseenbuff, 1); | |||
| for (int x = 0; x < 256; x++) | |||
| memset(&PaletteInterpolationTable[x][0], x, 256); | |||
| CopyType = 1; | |||
| Interpolate_2X_Scale(pseudoseenbuff, &SeenBuff, 0); | |||
| Settings.Video.InterpolationMode = 1; | |||
There was a problem hiding this comment.
Remove this assignment and use 1 in the call. Setting it will change the ini value to 1 after you quit the game.
| @@ -1697,23 +1692,23 @@ void Multi_Score_Presentation(void) | |||
| Animate_Frame(anim, *pseudoseenbuff, 1); | |||
| for (int x = 0; x < 256; x++) | |||
| memset(&PaletteInterpolationTable[x][0], x, 256); | |||
| CopyType = 1; | |||
There was a problem hiding this comment.
You can either revert these changes because they are ifdeffed out or fix them to use the argument as well.
OmniBlade
force-pushed
the
feature/interpolate
branch
from
8f1fe66
to
6aa0b8d
Compare
hifi
approved these changes
Feb 12, 2021
Changes default interpolation from scanline to full linear. Adds option for conquer.ini/redalert.ini [Video] section, InterpolationMode=x 0 = Horizontal interpolation, vertical skip scanline. 1 = Horizontal interpolation, vertical doubling. 2 = Full interpolation in both axis.
OmniBlade
force-pushed
the
feature/interpolate
branch
from
6aa0b8d
to
7b2b1ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appearance on scaled resolutions that are not integer scaled is much improved.