-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux support to the project #13
Conversation
@@ -1,6 +1,6 @@ | |||
#pragma once | |||
|
|||
#ifdef HZ_PLATFORM_WINDOWS | |||
#if defined HZ_PLATFORM_WINDOWS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a bit redundant to do platform checks when the code is the same for both platforms right now.
if there are divergences later on then they can be added at that point in time.
TLDR; may as well just remove the if platform
checks for now. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Cherno,
- added support for Linux to the premake5.lua file
- changed the "Hazel/Hazel/src/Hazel/Events/Event.h" to fix gcc compile error:
src/Hazel/Events/Event.h:32:83: error: pasting "::" and "WindowResize" does not give a valid preprocessing token
#define EVENT_CLASS_TYPE(type) static EventType GetStaticType() { return EventType::##type; }- changed files: "Hazel/src/Hazel/Core.h" and "Hazel/src/Hazel/EntryPoint.h" to add support for Linux
Thanks.
Marian
#define EVENT_CLASS_TYPE(type) static EventType GetStaticType() { return EventType::##type; }
#define EVENT_CLASS_TYPE(type) static EventType GetStaticType() { return EventType::type; }
I am using gcc on windows i just delete '##', it works
Can you please update this branch and make sure it's ready to merge? I'd be keen to merge this in. 🙂 |
I updated this PR on #27 |
As this PR is already updated on #27 , perhaps this one should be closed as it is obsolete, right? |
On Manjaro 18.0.3, I am getting an error after running
|
@ritobanrc this is already fixed on PR #27 (I myself use manjar too, so it should work for you aswell) |
I cloned the latest marian-bielcik/Hazel branch and found it works with a minor modification. I cloned the project.
Modified
Ran premake with make.
And Sandbox compiled properly! It was cubedtear's branch that worked for me a few months ago. I contributed a little documentation to his branch too. I attempted to rebase cubetear's branch from TheCherno's latest work but I found myself stuck after making some modifications. Now I'm wondering what the differences are between the @cubedtear and @marian-bielcik branches. |
Closing since this has been moved to #27 |
This branch looks to be the most promising Pull Request for Linux support! The latest repository is 3 commits behind. A proper repository clone compiles and runs fine on my system. The submodule links need to be changed to point back to TheCherno's repositories. |
Hi Cherno,
src/Hazel/Events/Event.h:32:83: error: pasting "::" and "WindowResize" does not give a valid preprocessing token
#define EVENT_CLASS_TYPE(type) static EventType GetStaticType() { return EventType::##type; }
Thanks.
Marian