Add Linux support (updated) #27

cubedtear · 2019-02-03T16:34:43Z

I have based this PR off of #13 and updated it. This PR requires merging other two PRs in submodules, so that the libraries can be built on Linux. These are the PRs:

…s suggestion

MichelMelhem · 2019-02-04T18:44:18Z

wow

Linux setup instructions

…d added common ones

cubedtear · 2019-02-05T18:29:10Z

I merged a PR made by @DaveAxiom in my fork that adds a README.md file with the necessary steps to build Hazel on Linux (as well as some basic info).
If I recall correctly, @TheCherno metioned in a video the readme should explain how to make issues, PRs and similar things, but I think this is a good starting point.

WhoseTheNerd · 2019-02-09T10:22:57Z

Hazel/src/Hazel/Core.h

@@ -1,27 +1,37 @@
 #pragma once

-#ifdef HZ_PLATFORM_WINDOWS
+#if defined HZ_PLATFORM_WINDOWS
+        #define HZ_DEBUG_BREAK { __debugbreak(); }


Wouldn't it be cleaner to use function macros?

Suggested change

#define HZ_DEBUG_BREAK { __debugbreak(); }

#define HZ_DEBUG_BREAK() __debugbreak()

cubedtear · 2019-02-09T10:39:07Z

@WhoseTheNerd I did it to be consistent with other macros. For example, HZ_ASSERT is just an if statement with its own braces. However, it is still surrounded by braces. Not how I would do it, but to follow the existing style.

ritobanrc · 2019-02-26T06:38:54Z

On Majaro 18.0.3, I am getting

ERROR: ImGui_ImplOpenGL3_CreateDeviceObjects: failed to compile vertex shader!
0:1(10): error: GLSL 4.10 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, 3.00 ES, 3.10 ES, and 3.20 ES

ERROR: ImGui_ImplOpenGL3_CreateDeviceObjects: failed to compile fragment shader!
0:1(10): error: GLSL 4.10 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, 3.00 ES, 3.10 ES, and 3.20 ES

ERROR: ImGui_ImplOpenGL3_CreateDeviceObjects: failed to link shader program! (with GLSL '#version 410
')
error: linking with uncompiled/unspecialized shadererror: linking with uncompiled/unspecialized shader
[1]    16787 segmentation fault (core dumped)  ./Sandbox

This may have something to do with git submodule update --init failing:

error: Server does not allow request for unadvertised object 009d641dc8966e3e61aedb190113cf6513c3d98c
Fetched in submodule path '../../../Hazel/vendor/imgui', but it did not contain 009d641dc8966e3e61aedb190113cf6513c3d98c. Direct fetching of that commit failed.

Any suggestions?

cubedtear · 2019-02-26T23:04:26Z

@ritobanrc I think they are two separate issues.
On the one hand, regarding the submodules, you will need to add my fork on those as remotes and fetch from them, in order for you to have the needed commits (this will be solved once the PRs in the description are merged).

On the other hand, I have not dedicated enough time to check those shaders, but by the looks of it, your hardware/drivers do not support the necessary OpenGL version. This could be solved by installing the latest drivers for your video card.
If you cannot solve it, open an issue on my fork and we will discuss it there 😊

jonestristand · 2019-03-19T09:43:20Z

Wow that's a lot of work, awesome! I do think that there should be a separate LinuxWindow class in platform, rather than modifying the WindowsWindow to work with Linux. Then select which platform-appropriate window class to use based on macros...

ritobanrc · 2019-03-21T21:16:55Z

@cubedtear I just re-cloned the project, and the submodule issue seems to have resolved itself. However, I'm still getting the issue with OpenGL and ImGui. This is the output of glxinfo | grep version,

server glx version string: 1.4
client glx version string: 1.4
GLX version: 1.4
    Max core profile version: 4.5
    Max compat profile version: 3.0
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
OpenGL core profile version string: 4.5 (Core Profile) Mesa 18.3.4
OpenGL core profile shading language version string: 4.50
OpenGL version string: 3.0 Mesa 18.3.4
OpenGL shading language version string: 1.30
OpenGL ES profile version string: OpenGL ES 3.2 Mesa 18.3.4
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

I have mesa 18.3.4-1 and xf86-video-intel 1:2.99.917+860+g3a2dec17-1 installed. Any suggestions?

I also tested the example_glfw_opengl2 and example_glfw_opengl3 examples from from ocornut/imgui and TheCherno/imgui, and they both work. Is there a particular reason Hazel appears to be using OpenGL 4?

marian-bielcik · 2019-03-31T11:34:23Z

@ritobanrc I had the same issue.
Solution: I downloaded GLAD for GL 3.0 and put it into vendor/Glad folder.
My recommendation: put GLAD for GL 3.0 also into imgui/examples/libs/glad folder - for testing with just the imgui examples.
As far as I know Hazel does not (yet) require OpenGL 4, so for now, you/we should be fine with GLAD for GL 3.0

Gaztin · 2019-05-20T10:54:16Z

I suggest keeping the indentation method to tabs like it was before. it will make for a more pleasant diff and will comply with the current style of the engine. It will also be easier to merge.

DaveAxiom · 2019-06-11T04:43:19Z

https://github.com/cubedtear/Hazel/tree/master/Hazel/vendor
I spotted that the GLFW submodule link points to a false commit. The commit hash that the link points to was never pulled into TheCherno's branch! That could begin to explain why cubedtear's branch is faulty.

NiGhMa · 2019-06-29T19:54:31Z

@cubedtear Just to let you know I implemented your changes into my code running on Ubuntu 18.04 and it works perfectly! Thanks for your job! I'm working on my own version of the code here (https://github.com/NiGhMa/Hazelicious)

cubedtear · 2019-06-29T20:00:31Z

@cubedtear Just to let you know I implemented your changes into my code running on Ubuntu 18.04 and it works perfectly! Thanks for your job! I'm working on my own version of the code here (https://github.com/NiGhMa/Hazelicious)

Thank you for your kind words, @NiGhMa, both in the comment and in the shoutout on your readme! I have been a little absent in this project lately, but I'm truly glad this was helpful 😄

LovelySanta

In discord was asked if this can be looked at; I would suggest:

update premake files in submodules (see inital post)
fast forward the branch (pull master into this) so it can be merged
ask someone with write acces to review (gaztin for example)
wait till thecherno wants to make a video about this since this is not "just a bugfix"

LovelySanta · 2019-07-02T10:36:15Z

Hazel/src/Hazel/Core.h

@@ -1,27 +1,37 @@
 #pragma once

-#ifdef HZ_PLATFORM_WINDOWS
+#if defined HZ_PLATFORM_WINDOWS
+        #define HZ_DEBUG_BREAK { __debugbreak(); }


As @WhoseTheNerd suggested:

Wouldn't it be cleaner to use function macros?

Suggested change

#define HZ_DEBUG_BREAK { __debugbreak(); }

#define HZ_DEBUG_BREAK() __debugbreak()

Also added these changes in the assert statements

LovelySanta · 2019-07-02T10:36:22Z

Hazel/src/Hazel/Core.h

 #endif

 #ifdef HZ_DEBUG
 	#define HZ_ENABLE_ASSERTS
 #endif

 #ifdef HZ_ENABLE_ASSERTS
-	#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); __debugbreak(); } }
-	#define HZ_CORE_ASSERT(x, ...) { if(!(x)) { HZ_CORE_ERROR("Assertion Failed: {0}", __VA_ARGS__); __debugbreak(); } }
+	#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK; } }


Suggested change

#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK; } }

#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK(); } }

LovelySanta · 2019-07-02T10:36:41Z

Hazel/src/Hazel/Core.h

-	#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); __debugbreak(); } }
-	#define HZ_CORE_ASSERT(x, ...) { if(!(x)) { HZ_CORE_ERROR("Assertion Failed: {0}", __VA_ARGS__); __debugbreak(); } }
+	#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK; } }
+	#define HZ_CORE_ASSERT(x, ...) { if(!(x)) { HZ_CORE_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK; } }


Suggested change

#define HZ_CORE_ASSERT(x, ...) { if(!(x)) { HZ_CORE_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK; } }

#define HZ_CORE_ASSERT(x, ...) { if(!(x)) { HZ_CORE_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK(); } }

LovelySanta · 2019-07-02T10:39:39Z

Hazel/src/Platform/Windows/WindowsWindow.cpp

@@ -1,14 +1,16 @@
 #include "hzpch.h"
+
+// Include GLAD before GLFW, because it otherwise causes a compile error on linux
+#include <glad/glad.h>


Instead of including it before the header file, why not move it into the header file at once; where GLFW and glad can be included next to each other?

DaveAxiom · 2019-07-03T17:36:43Z

@Gaztin Please close this PR and reopen #13 . This branch was abandoned in February while the parent branch is two weeks behind TheCherno:master.

LovelySanta · 2019-07-04T09:49:14Z

As mensioned in the comment TheCherno/imgui#3 (comment), Hazel is currently using the docking branch. In this case, can TheCherno/imgui#4 be added to the todo list in the first post @Gaztin?

Gaztin · 2019-07-04T10:51:32Z

Done

Gaztin · 2019-07-04T22:17:07Z

@DaveAxiom It all depends on the PR authors. If the author of #13 (@marian-bielcik) isn't active then there's no reason to reopen it.

LovelySanta · 2019-07-07T11:44:34Z

@Gaztin TheCherno/imgui#4 can be checked off in the task list ^_^

LovelySanta · 2019-07-07T19:10:28Z

At @DaveAxiom's request I've created new PR's (see references above this comment) in the submodules to expedite the PR's. These are final and can be merged.

Once these are merged by cherno, those tasks can be ticked off.

ShantanuJamble · 2019-07-12T22:19:55Z

@cubedtear I was referring this PR to write a premake file for my repo. In addition to the links you have in the repo, I also needed to put in dl. to know the linking errors I faced you can check out following links,
https://stackoverflow.com/questions/48136263/makefile-for-opengl-with-glad-on-linux.
Hope this is useful. :)

Gaztin · 2019-08-02T12:20:39Z

Closing since this has been picked up in #82 instead.

marian-bielcik and others added 6 commits January 1, 2019 17:38

Added support for Linux

78f93b2

Added "Makefile" to ignorelist

52a5c37

Added support for Linux

8f069b4

Update Core.h

a7181b9

Updated @marian-bielcik's branch to master, and applied CarwynNelson'…

27bcfa1

…s suggestion

Updated build script, submodules and GLAD includes to work on linux

e77d129

cubedtear mentioned this pull request Feb 3, 2019

Add Linux support to the project #13

Closed

DrBarnabus mentioned this pull request Feb 3, 2019

linux support #24

Closed

DaveAxiom added 2 commits February 4, 2019 01:40

Linux setup instructions

8c4f283

Markup fix, oops

d8a6cb0

cubedtear added 2 commits February 5, 2019 19:15

Merge pull request #1 from DaveAxiom/master

18bd6a1

Linux setup instructions

Modified README. Added instructions for Windows, improved Linux's, an…

c08c0d5

…d added common ones

Fixed mixed indentation to all spaces (4 spaces/level)

38151af

cubedtear mentioned this pull request Feb 5, 2019

Mac OS X support #6

Closed

MichaelObvious approved these changes Feb 9, 2019

View reviewed changes

WhoseTheNerd reviewed Feb 9, 2019

View reviewed changes

DaveAxiom mentioned this pull request Mar 3, 2019

Vendor folder not present #44

Closed

Gaztin added the OS:Linux Operating system Linux label May 20, 2019

LovelySanta reviewed Jul 2, 2019

View reviewed changes

Gaztin mentioned this pull request Jul 2, 2019

sandbox not working while debugging in mvs #60

Closed

This was referenced Jul 7, 2019

Add support for Linux (expedite from #1) TheCherno/glfw#6

Merged

Add support for Linux (expedite from #3) TheCherno/imgui#5

Closed

LovelySanta mentioned this pull request Jul 11, 2019

Linux support (up-to-date) #82

Open

7 tasks

Gaztin closed this Aug 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Linux support (updated) #27

Add Linux support (updated) #27

cubedtear commented Feb 3, 2019 •

edited by Gaztin

MichelMelhem commented Feb 4, 2019

cubedtear commented Feb 5, 2019 •

edited

WhoseTheNerd Feb 9, 2019 •

edited

cubedtear commented Feb 9, 2019

ritobanrc commented Feb 26, 2019

cubedtear commented Feb 26, 2019 •

edited

jonestristand commented Mar 19, 2019

ritobanrc commented Mar 21, 2019 •

edited

marian-bielcik commented Mar 31, 2019

Gaztin commented May 20, 2019

DaveAxiom commented Jun 11, 2019

NiGhMa commented Jun 29, 2019

cubedtear commented Jun 29, 2019

LovelySanta left a comment •

edited

LovelySanta Jul 2, 2019 •

edited

LovelySanta Jul 2, 2019

LovelySanta Jul 2, 2019

LovelySanta Jul 2, 2019

DaveAxiom commented Jul 3, 2019

LovelySanta commented Jul 4, 2019

Gaztin commented Jul 4, 2019

Gaztin commented Jul 4, 2019

LovelySanta commented Jul 7, 2019

LovelySanta commented Jul 7, 2019

ShantanuJamble commented Jul 12, 2019

Gaztin commented Aug 2, 2019

	#define HZ_DEBUG_BREAK { __debugbreak(); }
	#define HZ_DEBUG_BREAK() __debugbreak()

	#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK; } }
	#define HZ_ASSERT(x, ...) { if(!(x)) { HZ_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK(); } }

	#define HZ_CORE_ASSERT(x, ...) { if(!(x)) { HZ_CORE_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK; } }
	#define HZ_CORE_ASSERT(x, ...) { if(!(x)) { HZ_CORE_ERROR("Assertion Failed: {0}", __VA_ARGS__); HZ_DEBUG_BREAK(); } }

Add Linux support (updated) #27

Add Linux support (updated) #27

Conversation

cubedtear commented Feb 3, 2019 • edited by Gaztin

MichelMelhem commented Feb 4, 2019

cubedtear commented Feb 5, 2019 • edited

WhoseTheNerd Feb 9, 2019 • edited

Choose a reason for hiding this comment

cubedtear commented Feb 9, 2019

ritobanrc commented Feb 26, 2019

cubedtear commented Feb 26, 2019 • edited

jonestristand commented Mar 19, 2019

ritobanrc commented Mar 21, 2019 • edited

marian-bielcik commented Mar 31, 2019

Gaztin commented May 20, 2019

DaveAxiom commented Jun 11, 2019

NiGhMa commented Jun 29, 2019

cubedtear commented Jun 29, 2019

LovelySanta left a comment • edited

Choose a reason for hiding this comment

LovelySanta Jul 2, 2019 • edited

Choose a reason for hiding this comment

LovelySanta Jul 2, 2019

Choose a reason for hiding this comment

LovelySanta Jul 2, 2019

Choose a reason for hiding this comment

LovelySanta Jul 2, 2019

Choose a reason for hiding this comment

DaveAxiom commented Jul 3, 2019

LovelySanta commented Jul 4, 2019

Gaztin commented Jul 4, 2019

Gaztin commented Jul 4, 2019

LovelySanta commented Jul 7, 2019

LovelySanta commented Jul 7, 2019

ShantanuJamble commented Jul 12, 2019

Gaztin commented Aug 2, 2019

cubedtear commented Feb 3, 2019 •

edited by Gaztin

cubedtear commented Feb 5, 2019 •

edited

WhoseTheNerd Feb 9, 2019 •

edited

cubedtear commented Feb 26, 2019 •

edited

ritobanrc commented Mar 21, 2019 •

edited

LovelySanta left a comment •

edited

LovelySanta Jul 2, 2019 •

edited