Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme #290

Merged
merged 40 commits into from
Oct 5, 2020
Merged

Updated Readme #290

merged 40 commits into from
Oct 5, 2020

Conversation

BEASTSM96
Copy link
Contributor

Description

Updated readme. Moved the hazel-dev below the main features to come: part. And added Cherno's other links (aka discord, youtube, etc..).

@LovelySanta LovelySanta added the Impact:Suggestion Suggestions label Aug 6, 2020
Copy link
Collaborator

@LovelySanta LovelySanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a particular fan of the changes in the readme of swapping the plan under the future works, since cherno did set them up himself. However I do like the idea of the links, we had the idea already to put links into the readme, however we thought of doing it with buttons as you can see in the about section of this linux branch.

This would look something like this below (in no particular order):

Twitter Instagram Youtube Discord

We also thought about linking the community driven wiki in the future, once we have some content on there. You can find it on github (TheChernoCommunity/HazelWiki) and is published at thechernocommunity.github.io/HazelWiki. I might come around this week to write a decent front page for it.

Back on the review of this PR... Please revert the changes to imgui.ini, as cherno doesn't want changes committed, as mentioned in #204 (comment). Similarly, do not add them to .gitignore.

@BEASTSM96
Copy link
Contributor Author

Ohh ok thanks for the info. I will revert the changes back to what you said Thanks.

@BEASTSM96
Copy link
Contributor Author

Fixed conflicts.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@BEASTSM96 BEASTSM96 changed the title Updated Readme.md Updated Readme Aug 13, 2020
@BEASTSM96
Copy link
Contributor Author

Ready for the next review.

Hazelnut/imgui.ini Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
BEASTSM96 and others added 2 commits September 14, 2020 07:11
Co-authored-by: lovely_santa <laurens.scheldeman@gmail.com>
@BEASTSM96
Copy link
Contributor Author

Yeah, your English was on point to be honest

README.md Outdated Show resolved Hide resolved
@BEASTSM96
Copy link
Contributor Author

Added

README.md Outdated Show resolved Hide resolved
@BEASTSM96
Copy link
Contributor Author

Fixed, simple mistake

@BEASTSM96 BEASTSM96 mentioned this pull request Sep 24, 2020
@LovelySanta LovelySanta added the Support:git Support about git/github label Sep 24, 2020
@BEASTSM96
Copy link
Contributor Author

BEASTSM96 commented Sep 26, 2020

Added a "What Hazel support" (not the real name) thing

Copy link
Contributor Author

@BEASTSM96 BEASTSM96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, there is a branch that has Linux support I have not added that cuz that's not in the main repo LOL that was going to be a comment, not a review

@LovelySanta
Copy link
Collaborator

I wouldn't add that tbh... You could use the shields from the linux branch, but I think that should be more part of "the plan" rather than a seperate section

@BEASTSM96
Copy link
Contributor Author

Yeah, I might remove that

README.md Outdated Show resolved Hide resolved
@LovelySanta LovelySanta merged commit fbdecd7 into TheCherno:master Oct 5, 2020
babaliaris pushed a commit to babaliaris/Hazel that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact:Suggestion Suggestions Support:git Support about git/github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants