Poetry conversion #10
Conversation
colton-herrod-bayer
requested review from
roshini-saravanakumar,
austin-cao and
matthew-climate
|
Its an open question on if we even want to do this. Poetry is one of our internal standards and using it in our owned OSS projects makes things easier for us. It is a bit of a shift for the project itself, though. Input from the rest of the team would be useful here. |
| import yaml | ||
|
|
||
| # | ||
| file_manager = ExitStack() |
There was a problem hiding this comment.
it is not clear to me what we are doing with this. aren't cotnext managers usually used in 'with' blocks?
There was a problem hiding this comment.
This is part of the recommended migration from pkg_resources to importlib. This is the suggested pattern for files that need to persist for longer than a with block should be set up for. See here.
That said, I think I missed the bits needed to close the file. I'll get that set up shortly.
There was a problem hiding this comment.
i see, it looks like you might only need the ExitStack when you need the file to stick around for the life of the program and outside the context of the with. however, we just parse them and store the python objects in memory. so i think we can simply use the 'with' keyword. you might be able to avoid the file(s) and use https://importlib-resources.readthedocs.io/en/latest/migration.html#pkg-resources-resource-stream to pass a stream directly to json.load()/yaml.safe_load() too
| from . import expand_action | ||
| from .finding import Finding | ||
| from .misc import make_list | ||
| from .statement import Statement | ||
|
|
||
|
|
||
| class Policy: | ||
| _findings = [] | ||
| policy_json = None | ||
| _findings: list[Finding] = [] |
There was a problem hiding this comment.
im not sure these class variables serve any purpose... we can probably remove them and move the typing to the init's instance variables
There was a problem hiding this comment.
I don't know that they do either, but I'm inclined to leave that sort of change to a separate chunk of work. Do we want to track that in the repository?
Converting to use poetry, more modern code formatting tools, updating various dependencies, deprecated libraries, and other cleanup.