Fix some MAP issues #373
Merged
Fix some MAP issues #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge TheIOFoundation/ProjectLockdown "master" branch
Merge TheIOFoundation/ProjectLockdown "master" branch
Merge TheIOFoundation/ProjectLockdown "master" branch
Fix UI bugs (#222)
|
Deploy preview for dazzling-visvesvaraya-f47271 ready! Built with commit 8eb6428 https://deploy-preview-373--dazzling-visvesvaraya-f47271.netlify.app |
jeff-knurek
reviewed
May 15, 2021
Comment on lines
21
to
31
| t: s => { | ||
| switch (s) { | ||
| case 'menu.userPreferenceSection.theme.action': | ||
| return 'Toggle '; | ||
| return 'Switch to '; | ||
| case 'menu.userPreferenceSection.theme.light': | ||
| return 'Light mode'; | ||
| case 'menu.userPreferenceSection.theme.dark': | ||
| return 'Dark mode'; | ||
| case 'menu.userPreferenceSection.theme.dark': | ||
| return 'Light mode'; | ||
| default: | ||
| return s; | ||
| } |
There was a problem hiding this comment.
is this block obsolete? can you try removing it to confirm it all still works?
There was a problem hiding this comment.
locale itself needs to be passed to <Settings>, but it still works without the function.
|
Kudos, SonarCloud Quality Gate passed!
|
jeff-knurek
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #365, resolves #367, and resolves #369. Fixes most of #368 except for the final point.