Adding google font as a local asset, fixing missing font-face, adding… #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 and #40
Added 10 font files (.svg, .woff, .woff2, .eot,), when fetched from CDN, Google sends a file based on user agent, we need all file types that are used by various browsers.
Added Arial to font-family when Libre Franklin is unavailable. (TODO for the future, we may want to just modify font-family in one place in CSS that will cover all DOM elements such as: a, h1, h2...).
WebPack moves font files to a font folder, used "include" option because our fonts have .svg file, which normally WebPack would treat as any other image, but in our case, we need to keep it in the fonts folder.
Crossbrowser explanation for font-family:
@font-face {
font-family: 'MyWebFont';
src: url('webfont.eot'); /* IE9 Compat Modes /
src: url('webfont.eot?#iefix') format('embedded-opentype'), / IE6-IE8 /
url('webfont.woff2') format('woff2'), / Super Modern Browsers /
url('webfont.woff') format('woff'), / Pretty Modern Browsers /
url('webfont.ttf') format('truetype'), / Safari, Android, iOS /
url('webfont.svg#svgFontName') format('svg'); / Legacy iOS */
}