Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging reporting #11

Merged
merged 17 commits into from
Mar 9, 2021
Merged

Logging reporting #11

merged 17 commits into from
Mar 9, 2021

Conversation

erickmartins
Copy link
Collaborator

This pull request includes:

  • A fix for issue Import should stop immediately after failing to validate user/group #10 - we now throw a ValueError if user and/or group cannot be validated
  • Significant improvement on logging: user-side error (on spreadsheet mistakes, etc) are now logged on a time-stamped .log file placed in the dropbox folder. If a json file is generated and an import starts, the server-side folder that is created with the data and json file will also include a .out file (with all stdout output) and a .err file (with all stderr output), both time-stamped. This might be enough to solve need to mark an import target directory as complete #8
  • Empty imports do not throw an error any longer. An empty import event is logged in the log file but code goes through, skipping the import steps.

@erickmartins
added logging, raise error on user validation
35b7255 
Included:
1) better error messages on logging
2) logging saved to dropbox folder in timestamped file
3) all stdout and stderr saved to server folder in timestamped files (in case import starts)
4) raise ValueError on failed user/group validation instead of a warning, changed tests accordingly
@erickmartins
using absolute paths for sub-scripts
afda4bd
@erickmartins
moved basic log config to main
049d0c9
@erickmartins
check for existing json before trying to move
d532320
@erickmartins
debug print
543425d
@erickmartins
debug print
0a1312b
@erickmartins
debug print
77ddfa4
@erickmartins
debug print
60129de
@erickmartins
debug print
4ce9d68
@erickmartins
debug print
0a0c366
@erickmartins
skip trying to import if there is no json
81679ff
@erickmartins
using logger object
4b9766d
@erickmartins
removed debug print
07cc010
@erickmartins
fixed filename formatting
314c0a8
@erickmartins
added logging for successful import
f04ce55
@erickmartins
forgot the f in the f-string
9f3c585
@erickmartins
we probably don't want to give the user a server filepath
4d5f14b
@mellertd mellertd merged commit 981b98b into master Mar 9, 2021
@mellertd mellertd deleted the logging-reporting branch March 9, 2021 21:45
@mellertd mellertd mentioned this pull request May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erickmartins @mellertd