Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixes on COVERALLS_FLAG_NAME and COVERALLS_REPO_TOKEN for GitHub Actions #244

Merged
merged 1 commit into from Jan 12, 2021

Conversation

@andy-maier
Copy link
Contributor

@andy-maier andy-maier commented Nov 16, 2020

Addresses #243

…b Actions

Details:

* The docs section 'Github Actions Gotcha' stated that the COVERALLS_FLAG_NAME
  env var is needed in order to avoid 'pile up of jobs'. It turns out that
  it is optional, and when specified, can be specified with the same value
  across all jobs or with unique values.
  This change clarifies that in the documentation.

* This change also clarifies that the COVERALLS_REPO_TOKEN env var is not needed
  for GitHub Actions.

* This change also renames the heading of the section to 'Github Actions support'
  to have a more neutral name.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Copy link
Owner

@TheKevJames TheKevJames left a comment

@andy-maier thanks for the contribution, and I appreciate you helping to clean things up here. As you mentioned in #243, I think it would be useful to mention something about the "piling up" of jobs, even if it's not something we can fix. Could you include something to that effect here, to make sure users know that is expected?

@TheKevJames
Copy link
Owner

@TheKevJames TheKevJames commented Jan 12, 2021

Merging as this is a net improvement, but would love if you (@andy-maier ) had more info to add on the "piling up jobs" thing!

@TheKevJames TheKevJames merged commit 14cea5a into TheKevJames:master Jan 12, 2021
5 checks passed
5 checks passed
build (3.5)
Details
build (3.6)
Details
build (3.7)
Details
build (3.8)
Details
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants