Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globs in yadm encrypt not consistently reported or encrypted #109

Closed
neverfox opened this issue Mar 25, 2018 · 2 comments
Closed

Globs in yadm encrypt not consistently reported or encrypted #109

neverfox opened this issue Mar 25, 2018 · 2 comments
Assignees
Labels

Comments

@neverfox
Copy link

.yadm/encrypt

.awspm/profiles/**/*
.config/hub
.gnupg/*.gpg
.ssh/*.key
.weechat/ecdsa.pem
.weechat/sec.conf
.znc/configs/znc.conf
.znc/**/*.pem

> yadm encrypt

Encrypting the following files:
.awspm/profiles/personal/keys
.awspm/profiles/personal/neverfox.conf
.config/hub
.gnupg/trustdb.gpg
.ssh/id_rsa.key
.weechat/ecdsa.pem
.weechat/sec.conf
.znc/configs/znc.conf

Wrote new file: /Users/neverfox/.yadm/files.gpg

Note that .awspm/profiles/personal/keys/pkey.pub and .awspm/profiles/personal/keys/pkey aren't listed, only .awspm/profiles/personal/keys/. Also, no .pem files under .znc (though there are actually two).

> yadm decrypt

gpg: AES encrypted data
gpg: encrypted with 1 passphrase
.awspm/profiles/personal/keys/
.awspm/profiles/personal/keys/pkey.pub
.awspm/profiles/personal/keys/pkey
.awspm/profiles/personal/neverfox.conf
.config/hub
.gnupg/trustdb.gpg
.ssh/id_rsa.key
.weechat/ecdsa.pem
.weechat/sec.conf
.znc/configs/znc.conf
All files decrypted.

Note that .awspm/profiles/personal/keys/pkey.pub and .awspm/profiles/personal/keys/pkey are listed, despite what encrypt said, but it wasn't lying about not including the .znc/**/*.pem files that it should have included.

@rasa
Copy link
Contributor

rasa commented Apr 7, 2018

The double asterisks usage /**/* doesn’t work in bash, unless globstar is set via shopt -s globstar. See https://www.gnu.org/software/bash/manual/html_node/Pattern-Matching.html

@TheLocehiliosan TheLocehiliosan self-assigned this Nov 15, 2019
TheLocehiliosan added a commit that referenced this issue Nov 26, 2019
This will only work for Bash >=4, there the shell option "globstar" is
supported.
@TheLocehiliosan
Copy link
Owner

This has been added to the develop branch.

TheLocehiliosan added a commit that referenced this issue Nov 26, 2019
Update version number and update documentation

* Use relative symlinks for alternates (#100, #177)
* Support double-star globs in .config/yadm/encrypt (#109)
* Improve bash completion (#136)
* Update docs about using magit (#123)
* Note exception for WSL (#113)
TheLocehiliosan added a commit that referenced this issue Nov 27, 2019
Update version number and update documentation

* Use relative symlinks for alternates (#100, #177)
* Support double-star globs in .config/yadm/encrypt (#109)
* Improve bash completion (#136)
* Update docs about using magit (#123)
* Note exception for WSL (#113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants