Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Backtrack Solver #11

Merged
merged 6 commits into from
Feb 26, 2022
Merged

Implement Backtrack Solver #11

merged 6 commits into from
Feb 26, 2022

Conversation

TheMuppet
Copy link
Owner

No description provided.

@TheMuppet TheMuppet linked an issue Feb 25, 2022 that may be closed by this pull request
Backtrack-Solver #3
Closed
@TheMuppet TheMuppet changed the title Implement Brute Force Solver Implement Backtrack Feb 25, 2022
@TheMuppet TheMuppet changed the title Implement Backtrack Implement Backtrack Solver Feb 25, 2022
xTomsko
xTomsko requested changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@xTomsko xTomsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function "isConsistent" in "backtrackSolver.ts" would be a better fit in "utils.ts".
May need it for other implementations of solvers

@xTomsko
Copy link
Collaborator

xTomsko commented Feb 25, 2022

Please add testing for isConsistent

@TheMuppet
Copy link
Owner Author

Function "isConsistent" in "backtrackSolver.ts" would be a better fit in "utils.ts". May need it for other implementations of solvers

As far as I know, we will not need the "is consistent" function for other solvers. Therefore I would not export it to utils.ts

@TheMuppet TheMuppet merged commit 06a5784 into main Feb 26, 2022
@xTomsko xTomsko deleted the backrack-solver branch February 26, 2022 18:29
@xTomsko xTomsko mentioned this pull request Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xTomsko xTomsko xTomsko approved these changes

@alexsc23 alexsc23 alexsc23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backtrack-Solver
3 participants
@TheMuppet @xTomsko @alexsc23