Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-Queens Problem Test #6

Merged
merged 11 commits into from
Feb 21, 2022
Merged

N-Queens Problem Test #6

merged 11 commits into from
Feb 21, 2022

Conversation

alexsc23
Copy link
Collaborator

Review please

@alexsc23 alexsc23 self-assigned this Feb 19, 2022
@alexsc23 alexsc23 linked an issue Feb 19, 2022 that may be closed by this pull request
Base automatically changed from Brute-Force-Solver to main February 19, 2022 17:57
Copy link
Collaborator

@xTomsko xTomsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@TheMuppet
Copy link
Owner

I refactored the csp layout in #7. Please adjust the current changes and make sure the automatic tests are working

changed "let" to "const" when possible
fmt
Copy link
Collaborator

@xTomsko xTomsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@xTomsko
Copy link
Collaborator

xTomsko commented Feb 19, 2022

locally the Deno error does not occur, maybe flase-positve. needs to be checked by second reviewer @TheMuppet

@TheMuppet
Copy link
Owner

locally the Deno error does not occur, maybe flase-positve. needs to be checked by second reviewer @TheMuppet
Fixed It

@TheMuppet TheMuppet closed this Feb 20, 2022
@TheMuppet TheMuppet reopened this Feb 20, 2022
@TheMuppet
Copy link
Owner

With the test the answer of the csp is not really checked. Please implement a function that verifies the result. The function will be helpful in the future once we implement other solvers.

@xTomsko xTomsko merged commit 4d243ee into main Feb 21, 2022
@xTomsko xTomsko deleted the n-queens-problem-test branch February 21, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

N-Queens Problem Testcase
3 participants