flex: 06-flex-layout: README.md: Improve self check clarity #360
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is to keep with the flex spirit - Another solution might instead be to nest .input and .buttons into their own container, then apply the gap property to that container. This solves the visually uneven spacing between <img> and .input
AngryBabushka
pushed a commit
to AngryBabushka/css-exercises
that referenced
this pull request
Feb 23, 2024
…check_clarity flex: 06-flex-layout: README.md: Improve self check clarity
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
README.md says "There is space between the logo, input and buttons", but the related solution.css only gives space between the input and buttons via "margin-bottom: 16px;" applied to .input
This improves clarity of the README.md "Self Check" section by adding actual CSS "space between the logo, input and buttons", instead of the current arrangement with space only between the input and buttons.
This PR
margin-bottom: 16px;from.inputgap: 16pxinstead on their container:.contentIssue
Closes #349
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.01-flex-center: Update self checkBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection