Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation Overview: Provide descriptive link text #27697

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Installation Overview: Provide descriptive link text #27697

merged 3 commits into from
Mar 28, 2024

Conversation

Rllopez0410
Copy link
Contributor

@Rllopez0410 Rllopez0410 commented Mar 27, 2024

Updated text surrounding the link with the given text in the excel sheet.

Because

Update the text in the the Installation Overview lesson that surround the links with the the preferred content that was given via excel.

This PR

  • Removed the wiki link related to OS.
  • Modified other text surrounding the links with the requested changes given via excel.
  • Removed the word this within the text surrounding the VM link.

Issue

Related to #27681

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Updated text surrounding the link with the given text in the excel sheet.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Mar 27, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for getting this lesson sorted! Good catch on the VM video link which I missed. There's a change I've suggested which should resolve those issues.

foundations/installations/installation_overview.md Outdated Show resolved Hide resolved
foundations/installations/installation_overview.md Outdated Show resolved Hide resolved
@MaoShizhong MaoShizhong self-assigned this Mar 27, 2024
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the link up. Could you delete line 48 (the bullet point) since it's no longer needed?

@Rllopez0410
Copy link
Contributor Author

Of course, I didn't realize it was still there. Line 48 has been removed.

@MaoShizhong MaoShizhong merged commit 04b2848 into TheOdinProject:main Mar 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants