Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining 8.xx #47

Merged
merged 4 commits into from
May 6, 2024
Merged

Add remaining 8.xx #47

merged 4 commits into from
May 6, 2024

Conversation

Al-Azif
Copy link
Contributor

@Al-Azif Al-Azif commented May 5, 2024

  • 8.00, 8.01, and 8.03 offsets all appear to be the same
  • 8.52 appears to match 8.50
  • 9.51 appears to match 9.50/9.60

Untested, just happened to have 99% off the offsets from other stuff

- 8.00, 8.01, and 8.03 offsets all appear to be the same
- 8.52 appears to match 8.50
- 9.51 appears to match 9.50/9.60
@iMrDJAi
Copy link
Contributor

iMrDJAi commented May 5, 2024

@Al-Azif Awesome! Was going to begin working on FW 8.00. Thank you so much for your contribution!

@Al-Azif
Copy link
Contributor Author

Al-Azif commented May 5, 2024

Any reason why @kmeps4 opened up a new PR, without putting me as a co-author even, rather than just confirming this commit works? As now this PR is in conflict.

@kmeps4
Copy link
Contributor

kmeps4 commented May 5, 2024

Any reason why @kmeps4 opened up a new PR, without putting me as a co-author even, rather than just confirming this commit works? As now this PR is in conflict.

Sorry Azif but I also fixed some typo you had on the stage1 and stage2 and one bad offset as oxf0xf typo also... I didn't saw any issues doing a PR with the fixes.. credits are all yours!!!

@Al-Azif
Copy link
Contributor Author

Al-Azif commented May 5, 2024

Normally you'd commit to my branch and co-authoring is done like this https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors. I'm just mentioned in the PR title.

@iMrDJAi
Copy link
Contributor

iMrDJAi commented May 5, 2024

A strategic mistake I see here 🫠

Co-authored-by:  Kameleon <77245601+kmeps4@users.noreply.github.com>
@Al-Azif
Copy link
Contributor Author

Al-Azif commented May 5, 2024

Well this PR matches the repo now, just with some semblance of proper credit

@fabianlanza
Copy link

Any reason why @kmeps4 opened up a new PR, without putting me as a co-author even, rather than just confirming this commit works? As now this PR is in conflict.

Dam lol

@TheOfficialFloW TheOfficialFloW merged commit 753d1bf into TheOfficialFloW:master May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants