Cleaning up leftovers after extracting ValidateSelection use-case Gem. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified "validate selection"'s main test suite to use the new `Result` object per new-standard use-case protocol. That test suite goes away next. 272 tests, 310 assertions, 0 failures, 0 errors, 0 skips Coverage: 2509 / 2511 LOC (99.92%) covered. RuboCop: 90 files inspected, no offenses detected Flay: Total score 0 Flog: Total 713.1; method average 3.3; max 6.6 (Prolog::UseCases::AcceptSingleProposal#entity_attribs) Reek: 0 warnings
262 tests, 300 assertions, 0 failures, 0 errors, 0 skips Coverage: 2452 / 2454 LOC (99.92%) covered. RuboCop: 89 files inspected, no offenses detected Flay: Total score 0 Flog: Total 713.1; method average 3.3; max 6.6 (Prolog::UseCases::AcceptSingleProposal#entity_attribs) Reek: 0 warnings
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Issue #71. New Gem uses revised use-case protocol rather than arbitrary public attributes.