This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Update api to remove responsability of the library to coerce the urls #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new trace option for external calls
The goal is to get insights about external calls and which one might be under performing.
New external call trace api
This PRs adds a new option on external calls tracer to change the metric name. This can improve how you track performance of you external calls.
The current API still works exactly before, it will set the metric name for the module + function name of your call if no
:metric_name
is sent. But when a:metric_name
is passed, it will override the module + function name.A
:metric_name
can be defined in two ways, the first one is a string or a{Module, :function}
that will be called with the function args to return the string, allowing name to be defined at runtime. Below is the examples of usage of the@trace
with the current and new apis.The metric name includes the
External/
and/all
since they are necessary for NewRelic api to process the metric correctly.This is helpful for HTTP clients implementations like HTTPoison.