Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game of Life in Scala #1039

Merged
merged 3 commits into from Mar 22, 2019
Merged

Conversation

veevidify
Copy link
Contributor

Congrats on taking the first step to contributing to the Sample Programs in Every Language repository!

For simplicity, please make sure that your pull request includes one and only one sample program and language.

Please Complete the Following

  • I would NOT like credit for my contribution in the article (credit will be included otherwise)
  • I plan to write the article for this code snippet
  • I named the pull request using <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)
  • I fixed #your-issue-number-here

Notes

Feel free to put whatever you want here.

@jrg94 jrg94 requested a review from a team March 22, 2019 03:51
@jrg94 jrg94 self-assigned this Mar 22, 2019
@jrg94 jrg94 added the enhancement Any code that improves the repo label Mar 22, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Mar 22, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this one looks good as far as I can tell. I don't have a means of running it on my machine at the moment, so I'll trust that it works. It looks a lot like my Java implementation anyhow. 👍 Only change is the removal of that .gitignore.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🥇

@jrg94 jrg94 merged commit 80d3860 into TheRenegadeCoder:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants