Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added C# Testing #1053

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Added C# Testing #1053

merged 2 commits into from
Mar 30, 2019

Conversation

jrg94
Copy link
Member

@jrg94 jrg94 commented Mar 29, 2019

Congrats on taking the first step to contributing to the Sample Programs in Every Language repository!

For simplicity, please make sure that your pull request includes one and only one sample program and language.

Please Complete the Following

  • I would NOT like credit for my contribution in the article (credit will be included otherwise)
  • I plan to write the article for this code snippet
  • I named the pull request using <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)
  • I fixed #your-issue-number-here

Notes

Feel free to put whatever you want here.

@jrg94 jrg94 requested a review from a team March 29, 2019 15:19
@jrg94 jrg94 assigned auroq and jrg94 Mar 29, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo tests Testing related labels Mar 29, 2019
@jrg94 jrg94 marked this pull request as ready for review March 30, 2019 20:54
@jrg94
Copy link
Member Author

jrg94 commented Mar 30, 2019

All C# tests pass now! 🥇

@jrg94 jrg94 merged commit dea6bc1 into master Mar 30, 2019
@jrg94 jrg94 deleted the c-sharp-testing branch March 30, 2019 20:55
@auroq
Copy link
Contributor

auroq commented Mar 31, 2019

Good catch. I wondered if it was something like that, but didn't have time to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@auroq auroq

@jrg94 jrg94

Labels
enhancement Any code that improves the repo tests Testing related
Projects
Testing
Archived in project
Milestone
25 Language Tests
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrg94 @auroq