Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README to include Baklava in Elixir #1158

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Updated README to include Baklava in Elixir #1158

merged 2 commits into from
Oct 3, 2019

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Oct 3, 2019 •
edited

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

@jrg94 jrg94 requested a review from a team October 3, 2019 15:32
jrg94
jrg94 requested changes Oct 3, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! Just one quick change.

archive/e/elixir/README.md Outdated
@@ -6,6 +6,7 @@ Welcome to Sample Programs in Elixir!

- [Fizz Buzz in Elixir](https://github.com/TheRenegadeCoder/sample-programs/issues/1102)
- [Hello World in Elixir](https://therenegadecoder.com/code/hello-world-in-elixir/)
- [Baklava in Elixir](https://github.com/ogabrielluiz/sample-programs/blob/master/archive/e/elixir/baklava.ex/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But we usually link articles here. Since there isn't one, we try to make issues in their place. Then, we link the issue here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it. Thanks for the help!

@jrg94 jrg94 requested a review from a team October 3, 2019 15:34
@jrg94 jrg94 self-assigned this Oct 3, 2019
@jrg94 jrg94 added bug Something isn't working baklava See: https://sampleprograms.io/projects/baklava/ labels Oct 3, 2019
jrg94
jrg94 approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the help.

@jrg94 jrg94 merged commit 44f7794 into TheRenegadeCoder:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
baklava See: https://sampleprograms.io/projects/baklava/ bug Something isn't working
Projects
Documentation
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Elixir Documentation
2 participants
@ogabrielluiz @jrg94