Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Factorial in Kotlin #1193

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Added Factorial in Kotlin #1193

merged 1 commit into from
Oct 6, 2019

Conversation

satyajiit
Copy link
Contributor

Solution Code.

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I names the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 6, 2019 19:35
@jrg94 jrg94 self-assigned this Oct 6, 2019
@jrg94 jrg94 added the enhancement Any code that improves the repo label Oct 6, 2019
@jrg94 jrg94 changed the title Added Factorial of a number to Kotlin Added Factorial in Kotlin Oct 6, 2019
@jrg94 jrg94 added factorial See: https://sampleprograms.io/projects/factorial/ hacktoberfest Hacktoberfest related labels Oct 6, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 6, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this fully conforms with the project spec, but we can address that later when we add testing.

@jrg94 jrg94 merged commit 038c177 into TheRenegadeCoder:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/ hacktoberfest Hacktoberfest related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants