Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Capitalize in C #1516

Merged
merged 6 commits into from
Oct 10, 2019
Merged

Added Capitalize in C #1516

merged 6 commits into from
Oct 10, 2019

Conversation

Softizo
Copy link
Contributor

@Softizo Softizo commented Oct 10, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 10, 2019 00:59
@jrg94 jrg94 self-assigned this Oct 10, 2019
@jrg94 jrg94 added capitalize See: https://sampleprograms.io/projects/capitalize/ enhancement Any code that improves the repo hacktoberfest Hacktoberfest related labels Oct 10, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 10, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like we have any formal tests for this, so this looks good.

@jrg94 jrg94 merged commit f2a4b41 into TheRenegadeCoder:master Oct 10, 2019
Copy link
Contributor

@wileymab wileymab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aborting review. Already merged.

Comment on lines +16 to +24
int main(int argc, char *argv[]) {
if(argc == 2) {
printf("Result: %s\n", captialize(argv[1]));
} else if(argc > 2) {
printf("Use quotes around multiple strings.\n");
} else {
printf("Expected an argument.\n");
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements call out that there should be a check to verify the the input is a string and not a number. Can that check be added here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a good opportunity to put together some formal tests in the documentation. I've put it off because @auroq usually helps us write those, but we can do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capitalize See: https://sampleprograms.io/projects/capitalize/ enhancement Any code that improves the repo hacktoberfest Hacktoberfest related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Capitalize in C
3 participants