Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Palindrome in Python #1550

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Added Palindrome in Python #1550

merged 3 commits into from
Mar 24, 2020

Conversation

Anuj-Attri
Copy link
Contributor

@Anuj-Attri Anuj-Attri commented Oct 10, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 changed the title Create string_palindrome.py Added Palindrome in Python Oct 10, 2019
@jrg94 jrg94 requested a review from a team October 10, 2019 16:58
@jrg94 jrg94 self-assigned this Oct 10, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related labels Oct 10, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 10, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we currently support palindromes. Check the projects page. Feel free to write up the documentation for it!

@jrg94
Copy link
Member

jrg94 commented Mar 24, 2020

I'm going to go ahead and merge this for now. However, I will be making a documentation for this, and I am certain this solution will be changed. See #1866 for details.

@jrg94 jrg94 merged commit 5da9368 into TheRenegadeCoder:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants