Added a c++ library for working with fractions. #1558

Niraj-Kamdar · 2019-10-10T16:45:24Z

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

I fixed #your-issue-number-here

Code Snippets

I named the pull request using Added/Updated <Sample Program> in <Language> format
I created/updated the language README
- I added the sample program name to the README
- I added fun facts (i.e. debut, developer, typing, etc.)
- I added reference link(s) to the README
- I added solution citations when necessary (see plagiarism)

Documentation

I named the pull request using Added/Updated <Sample Program> in <Language> Article format
I followed the applicable article template
- I added/updated a language article (i.e. The Python Programming Language)
- I added/updated a code snippet article (i.e. Hello World in Perl)
- I added/updated a project article (i.e. Fizz Buzz in Every Language)

Testing

I named the pull request using Added/Updated <Language>/<Project> Testing format
I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

jrg94

Hey! This is really cool, but we currently don't have any support for it. Would you like to put the documentation together for this? See the projects page for examples.

jrg94 · 2019-10-10T19:03:46Z

This solution is a bit complicated, so I'll take a look shortly.

jrg94

Overall, I love the idea. However, libraries don't really fit well with our collections (though I'm open to the thoughts of others). If there's a way to make this runnable, that would be great!

jrg94 · 2019-10-10T19:07:14Z

docs/projects/fractions/_posts/2019-10-10-c-plus-plus.md

+featured-image:
+tags: [c-plus-plus, fractions]
+authors:
+  - niraj-kamdar


Make sure you add yourself to the author file. https://github.com/TheRenegadeCoder/sample-programs/blob/master/docs/_data/authors.yml

I'm going to mention this again.

If you add yourself to the authors file, we'll be good to go.

jrg94 · 2019-10-10T19:08:45Z

docs/projects/fractions/_posts/2019-10-10-c-plus-plus.md

+bottom will be assigned to denometor.Here we checks if denometor is zeros then we throws an error and if denomenator is
+negative then we negate top and bottom before assigning them.
+We also have to implement getters for this Class and a method for unary operator `-`.
+We also have to implement friend functions(one can use normal method) for binary operators like +, -, >=, == etc.


Here, we try to include a section for how to run the solution. It appears your solution is more of a library and less of an executable program.

docs/projects/fractions/index.md

jrg94 · 2019-10-10T19:11:25Z

I just noticed the main function! Any chance we could standardize it for user input?

Niraj-Kamdar · 2019-10-11T13:04:37Z

I have changed main function as required.

jrg94

Much better! My only ask now is that you fix up the project description to match our typical template. In addition, I think you're missing a section in your article.

Niraj-Kamdar · 2019-10-14T14:02:11Z

I don't know how to add article using syntax like this {% include article_list.md collection=site.categories.file-io %}.
so i am appending line -fill as needed to the article.

jrg94 · 2019-10-14T16:07:02Z

Let me know when you think it's ready for review.

Niraj-Kamdar · 2019-10-14T21:41:31Z

You can review it now. I guess i have completed all the requirements.

jrg94

Looks amazing! I'm really happy with how this turned out. Just a couple points.

jrg94 · 2019-10-14T22:24:22Z

docs/projects/fractions/_posts/2019-10-10-c-plus-plus.md

+featured-image:
+tags: [c-plus-plus, fractions]
+authors:
+  - niraj-kamdar


I'm going to mention this again.

docs/projects/fractions/_posts/2019-10-10-c-plus-plus.md

docs/projects/fractions/index.md

Co-Authored-By: Jeremy Grifski <jeremy.grifski@gmail.com>

jrg94

Looks just about ready! We just need you to add yourself to the authors file.

Niraj-Kamdar · 2019-10-15T02:09:16Z

i have updated authors.yml

jrg94

Awesome! We're in good shape.

Niraj-Kamdar added 2 commits October 10, 2019 21:55

A c++ library for working with fractions.

7303814

updated Readme for previous PR

eac8507

jrg94 requested changes Oct 10, 2019

View reviewed changes

jrg94 self-assigned this Oct 10, 2019

jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related labels Oct 10, 2019

jrg94 added this to the 500 Code Snippets milestone Oct 10, 2019

added fractions as new project

2fefaf6

jrg94 requested changes Oct 10, 2019

View reviewed changes

added arguments feature to use library

9bdfa30

jrg94 requested changes Oct 11, 2019

View reviewed changes

documentation update

e1bfb08

Niraj-Kamdar added 2 commits October 14, 2019 19:34

update article page

f810ebe

how to run

bf5501c

final change

8091e67

Merge branch 'master' into master

2616abc

jrg94 requested changes Oct 14, 2019

View reviewed changes

Niraj-Kamdar and others added 4 commits October 15, 2019 04:23

Update docs/projects/fractions/_posts/2019-10-10-c-plus-plus.md

81ca142

Co-Authored-By: Jeremy Grifski <jeremy.grifski@gmail.com>

testing table added

17384cf

Merge remote-tracking branch 'origin/master'

58cde23

Added articles section

0c67141

jrg94 requested changes Oct 15, 2019

View reviewed changes

jrg94 and others added 2 commits October 14, 2019 21:30

Removed extra space

82637d0

updare authors

df85c22

Merge remote-tracking branch 'origin/master'

5d7544e

Niraj-Kamdar closed this Oct 15, 2019

Niraj-Kamdar reopened this Oct 15, 2019

jrg94 approved these changes Oct 15, 2019

View reviewed changes

jrg94 added 2 commits October 14, 2019 22:54

Added missing author

4c12e52

Removed extra space

0f2024d

jrg94 merged commit 1a29ff9 into TheRenegadeCoder:master Oct 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a c++ library for working with fractions. #1558

Added a c++ library for working with fractions. #1558

Niraj-Kamdar commented Oct 10, 2019 •

edited

jrg94 left a comment

jrg94 commented Oct 10, 2019

jrg94 left a comment

jrg94 Oct 10, 2019

jrg94 Oct 14, 2019

jrg94 Oct 15, 2019

jrg94 Oct 10, 2019

jrg94 commented Oct 10, 2019

Niraj-Kamdar commented Oct 11, 2019

jrg94 left a comment

Niraj-Kamdar commented Oct 14, 2019

jrg94 commented Oct 14, 2019

Niraj-Kamdar commented Oct 14, 2019

jrg94 left a comment

jrg94 Oct 14, 2019

jrg94 left a comment •

edited

Niraj-Kamdar commented Oct 15, 2019

jrg94 left a comment

Added a c++ library for working with fractions. #1558

Added a c++ library for working with fractions. #1558

Conversation

Niraj-Kamdar commented Oct 10, 2019 • edited

Complete the Applicable Sections Below

Code Snippets

Documentation

Testing

Notes

jrg94 left a comment

Choose a reason for hiding this comment

jrg94 commented Oct 10, 2019

jrg94 left a comment

Choose a reason for hiding this comment

jrg94 Oct 10, 2019

Choose a reason for hiding this comment

jrg94 Oct 14, 2019

Choose a reason for hiding this comment

jrg94 Oct 15, 2019

Choose a reason for hiding this comment

jrg94 Oct 10, 2019

Choose a reason for hiding this comment

jrg94 commented Oct 10, 2019

Niraj-Kamdar commented Oct 11, 2019

jrg94 left a comment

Choose a reason for hiding this comment

Niraj-Kamdar commented Oct 14, 2019

jrg94 commented Oct 14, 2019

Niraj-Kamdar commented Oct 14, 2019

jrg94 left a comment

Choose a reason for hiding this comment

jrg94 Oct 14, 2019

Choose a reason for hiding this comment

jrg94 left a comment • edited

Choose a reason for hiding this comment

Niraj-Kamdar commented Oct 15, 2019

jrg94 left a comment

Choose a reason for hiding this comment

Niraj-Kamdar commented Oct 10, 2019 •

edited

jrg94 left a comment •

edited