Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Capitalize in Kotlin #1582

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Added Capitalize in Kotlin #1582

merged 2 commits into from
Oct 11, 2019

Conversation

gogeta95
Copy link
Contributor

@gogeta95 gogeta95 commented Oct 11, 2019 •
edited

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 changed the title Added capitalize in kotlin Added Capitalize in Kotlin Oct 11, 2019
@jrg94 jrg94 requested a review from a team October 11, 2019 23:28
@jrg94 jrg94 self-assigned this Oct 11, 2019
@jrg94 jrg94 added capitalize See: https://sampleprograms.io/projects/capitalize/ enhancement Any code that improves the repo hacktoberfest Hacktoberfest related labels Oct 11, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 11, 2019
jrg94
jrg94 approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not quite up to the requirements, but I'm not all that worried about it. Once testing is implemented in Kotlin, this will need to be updated.

@jrg94 jrg94 merged commit 17c2edc into TheRenegadeCoder:master Oct 11, 2019
@gogeta95
Copy link
Contributor Author

What do you mean by not quite upto requirements? Did i miss something?

@jrg94
Copy link
Member

jrg94 commented Oct 11, 2019

Ideally, the output should match what you see in the testing table: https://sample-programs.therenegadecoder.com/projects/capitalize/

In other words, the error message doesn't match, but it's no big deal.

@gogeta95
Copy link
Contributor Author

Ah, thanks for the clarification

@jrg94
Copy link
Member

jrg94 commented Oct 11, 2019

Yeah, sorry if that seemed like an attack! There are a ton of pull requests, so I've been trying to get through them quickly. 😆

@gogeta95 gogeta95 deleted the gogeta95-capitalize branch October 12, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
capitalize See: https://sampleprograms.io/projects/capitalize/ enhancement Any code that improves the repo hacktoberfest Hacktoberfest related
Projects
Code Snippets
Archived in project
Milestone
500 Code Snippets
Development

Successfully merging this pull request may close these issues.

Add Capitalize in Kotlin
2 participants
@gogeta95 @jrg94