Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Prime Number in C++ #1599

Merged
merged 9 commits into from
Oct 19, 2019
Merged

Added Prime Number in C++ #1599

merged 9 commits into from
Oct 19, 2019

Conversation

daffadaraz
Copy link
Contributor

since there is no prime number sample for C++

  • I created/added a program for prime-num.cpp in C++
  • I created/updated the language README
    • I added the sample program name to the README without URL

@jrg94 jrg94 requested a review from a team October 13, 2019 21:03
@jrg94 jrg94 self-assigned this Oct 13, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related prime number See: https://sampleprograms.io/projects/prime-number/ labels Oct 13, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 13, 2019
jrg94
jrg94 requested changes Oct 13, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just waiting on the testing. Also, one small change needed.

archive/c/c-plus-plus/README.md Outdated Show resolved Hide resolved
@daffadaraz @jrg94
Update archive/c/c-plus-plus/README.md
5685963 
Co-Authored-By: Jeremy Grifski <jeremy.grifski@gmail.com>
jrg94
jrg94 requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be failing testing: https://travis-ci.com/TheRenegadeCoder/sample-programs/jobs/245486396

@daffadaraz daffadaraz requested a review from jrg94 October 15, 2019 12:42
@jrg94
Copy link
Member

jrg94 commented Oct 18, 2019 •
edited

Looks like this is a failing a couple test cases. Take a look!

https://travis-ci.com/TheRenegadeCoder/sample-programs/jobs/245924745

jrg94
jrg94 requested changes Oct 18, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong term. Otherwise, we're good!

archive/c/c-plus-plus/prime-number.cpp Outdated Show resolved Hide resolved
daffadaraz and others added 2 commits October 19, 2019 22:55
@daffadaraz @jrg94
Update archive/c/c-plus-plus/prime-number.cpp
f8e6272 
Co-Authored-By: Jeremy Grifski <jeremy.grifski@gmail.com>
@daffadaraz
composite 0 and 1
48e225e
jrg94
jrg94 approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍶

@jrg94 jrg94 merged commit f23a3cf into TheRenegadeCoder:master Oct 19, 2019
@jrg94 jrg94 mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related prime number See: https://sampleprograms.io/projects/prime-number/
Projects
Code Snippets
Archived in project
Milestone
500 Code Snippets
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daffadaraz @jrg94