-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out test runner and replaced with glotter dependency #1606
Conversation
@jrg94 I think I finally got everything working now. I'll investigate it a little more before marking this ready for review. |
This is really exciting! 👍 |
Ya, this has been a lot of work, but I think I'm happy with the outcome. I would still like to find a better way to do the sorting tests, but that's out of scope for this I think. After this is merged, I'm going to see if I can get some more languages or projects setup for testing to try to keep up with all these hacktoberfest pull requests. |
Let me know when you think this is good to go, and I'll merge it! Also, I appreciate the help with the pull requests. They've been a huge pain to review, but I'm excited about it. |
Ya, I've been out of town for most of October, but I'm hoping to have some time to help out more the rest of this month. |
No sweat! I appreciate whatever help you can provide. |
@jrg94, The time has come. It's all ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to trust this is ready to go! We can work out any kinks if they show up. Looks great to me.
Looks like the master build is failing now for whatever reason.
Looks like it fails as it tries to grab the golang image: |
This is an issue with docker hub. See here: #1630 (comment) |
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated <Sample Program> in <Language>
formatDocumentation
Added/Updated <Sample Program> in <Language> Article
formatTesting
Added/Updated <Language>/<Project> Testing
formatNotes
Feel free to describe what you added or updated.