Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out test runner and replaced with glotter dependency #1606

Merged
merged 10 commits into from
Oct 15, 2019
Merged

Conversation

auroq
Copy link
Contributor

@auroq auroq commented Oct 14, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@auroq auroq added enhancement Any code that improves the repo tests Testing related labels Oct 14, 2019
@auroq auroq requested a review from jrg94 October 14, 2019 12:22
@auroq
Copy link
Contributor Author

auroq commented Oct 14, 2019

@jrg94 I think I finally got everything working now.
Just doing some last minute checks. On first glance, the number of tests doesn't match up between here and master, but there's a number of reasons why that could be.

I'll investigate it a little more before marking this ready for review.

@jrg94
Copy link
Member

jrg94 commented Oct 14, 2019

This is really exciting! 👍

@auroq
Copy link
Contributor Author

auroq commented Oct 14, 2019

Ya, this has been a lot of work, but I think I'm happy with the outcome. I would still like to find a better way to do the sorting tests, but that's out of scope for this I think.

After this is merged, I'm going to see if I can get some more languages or projects setup for testing to try to keep up with all these hacktoberfest pull requests.

@jrg94
Copy link
Member

jrg94 commented Oct 14, 2019

Let me know when you think this is good to go, and I'll merge it! Also, I appreciate the help with the pull requests. They've been a huge pain to review, but I'm excited about it.

@auroq
Copy link
Contributor Author

auroq commented Oct 14, 2019

Ya, I've been out of town for most of October, but I'm hoping to have some time to help out more the rest of this month.

@jrg94
Copy link
Member

jrg94 commented Oct 14, 2019

No sweat! I appreciate whatever help you can provide.

@auroq auroq marked this pull request as ready for review October 15, 2019 05:00
@auroq
Copy link
Contributor Author

auroq commented Oct 15, 2019

@jrg94, The time has come. It's all ready!

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to trust this is ready to go! We can work out any kinks if they show up. Looks great to me.

@jrg94 jrg94 merged commit 2d02db5 into master Oct 15, 2019
@jrg94 jrg94 deleted the glotter branch October 15, 2019 16:56
@jrg94
Copy link
Member

jrg94 commented Oct 15, 2019

Looks like the master build is failing now for whatever reason.

python runner.py download command is failing.

Looks like it fails as it tries to grab the golang image: Pulling golang:1.12-alpine

@auroq
Copy link
Contributor Author

auroq commented Oct 15, 2019

This is an issue with docker hub. See here: #1630 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants