Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Roman Numeral Conversion in PHP #1609

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Added Roman Numeral Conversion in PHP #1609

merged 1 commit into from
Oct 14, 2019

Conversation

ironsigma
Copy link
Contributor

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 14, 2019 19:22
@jrg94 jrg94 self-assigned this Oct 14, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related roman numeral See: https://sampleprograms.io/projects/roman-numeral/ labels Oct 14, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 14, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I didn't realize you could handle args like this. We may need to reevaluate some of the other PHP solutions.

@jrg94 jrg94 merged commit dba000a into TheRenegadeCoder:master Oct 14, 2019
@ironsigma ironsigma deleted the feature/roman-numerals-conversion branch October 14, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related roman numeral See: https://sampleprograms.io/projects/roman-numeral/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Roman Numeral Conversion in PHP
2 participants