-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PHP Testing #1624
Added PHP Testing #1624
Conversation
I wonder if there is a way we could mandate getting a testinfo.yml setup before adding sources for a language. My only concern is that a lot of languages don't have an official docker image. Pretty soon we're going to have to figure out what to do for those. |
Yeah, there's also the issue of enforcing tests for new projects as well. I think a lot of this stuff is a work in process, but I'm always happy to try to standardize a workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. This is exciting.
At any rate, @ironsigma has been working on a lot of PHP, and I think they've been doing a good job of adhering to the requirements. Some folks had misled me that you couldn't get command line arguments for PHP. Whoops! |
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated <Sample Program> in <Language>
formatDocumentation
Added/Updated <Sample Program> in <Language> Article
formatTesting
Added/Updated <Language>/<Project> Testing
formatNotes
Feel free to describe what you added or updated.