Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP Testing #1624

Merged
merged 10 commits into from
Oct 16, 2019
Merged

Added PHP Testing #1624

merged 10 commits into from
Oct 16, 2019

Conversation

auroq
Copy link
Contributor

@auroq auroq commented Oct 15, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@auroq auroq added the tests Testing related label Oct 15, 2019
@auroq auroq added this to the 25 Language Tests milestone Oct 15, 2019
@auroq auroq requested a review from jrg94 October 15, 2019 06:51
@auroq
Copy link
Contributor Author

auroq commented Oct 15, 2019

I wonder if there is a way we could mandate getting a testinfo.yml setup before adding sources for a language.

My only concern is that a lot of languages don't have an official docker image. Pretty soon we're going to have to figure out what to do for those.

@jrg94 jrg94 self-assigned this Oct 16, 2019
@jrg94
Copy link
Member

jrg94 commented Oct 16, 2019

Yeah, there's also the issue of enforcing tests for new projects as well. I think a lot of this stuff is a work in process, but I'm always happy to try to standardize a workflow.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. This is exciting.

@jrg94
Copy link
Member

jrg94 commented Oct 16, 2019

At any rate, @ironsigma has been working on a lot of PHP, and I think they've been doing a good job of adhering to the requirements. Some folks had misled me that you couldn't get command line arguments for PHP. Whoops!

@jrg94 jrg94 merged commit 5206dd2 into master Oct 16, 2019
@jrg94 jrg94 deleted the test-php branch October 16, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add PHP Testing
2 participants