Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Merge Sort in C #1629

Merged
merged 9 commits into from
Oct 16, 2019
Merged

Added Merge Sort in C #1629

merged 9 commits into from
Oct 16, 2019

Conversation

panda311
Copy link
Contributor

@panda311 panda311 commented Oct 15, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by [The Renegade Coder][1]! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see [plagiarism][2])

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template
    • I added/updated a [language article][4] (i.e. The Python Programming Language)
    • I added/updated a [code snippet article][3] (i.e. Hello World in Perl)
    • I added/updated a [project article][5] (i.e. Fizz Buzz in Every Language)

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@panda311
Copy link
Contributor Author

I don't get why it is failing the checks . It runs perfectly on my system .

@jrg94 jrg94 requested a review from a team October 15, 2019 17:58
@jrg94 jrg94 self-assigned this Oct 15, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related merge sort See: https://sampleprograms.io/projects/merge-sort/ labels Oct 15, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 15, 2019
@jrg94
Copy link
Member

jrg94 commented Oct 15, 2019

We use Docker to test code, and Docker is currently down. You may have to wait a bit to rerun your code. See random discussions strewn about in #1630, #1633, #1631 (etc.).

@jrg94
Copy link
Member

jrg94 commented Oct 15, 2019

Now, you should be able to see exactly what the errors are here: https://travis-ci.com/TheRenegadeCoder/sample-programs/jobs/245927112

Looks like GCC is failing to build. Are you using an external library?

@jrg94
Copy link
Member

jrg94 commented Oct 16, 2019

See:

E               RuntimeError: unable to build using cmd "gcc -o merge-sort merge-sort.c ":
E               merge-sort.c:4:9: fatal error: conio.h: No such file or directory
E                #include<conio.h>
E                        ^~~~~~~~~
E               compilation terminated.

@panda311
Copy link
Contributor Author

panda311 commented Oct 16, 2019

I have made the required changes in program (conio.h is not supported in linux environment) , but a new file has been added to list , thus there is a conflict in README.md .

@jrg94
Copy link
Member

jrg94 commented Oct 16, 2019

I was able to fix the conflict on my end!

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs great! Nice work.

@jrg94 jrg94 merged commit 697078d into TheRenegadeCoder:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related merge sort See: https://sampleprograms.io/projects/merge-sort/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Merge Sort in C
2 participants