Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quick Sort in JavaScript #1651

Merged
merged 14 commits into from
Oct 18, 2019
Merged

Added Quick Sort in JavaScript #1651

merged 14 commits into from
Oct 18, 2019

Conversation

Gurmeet22
Copy link
Contributor

@Gurmeet22 Gurmeet22 commented Oct 16, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated Quick Sort in Javascript format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 16, 2019 15:55
@jrg94 jrg94 self-assigned this Oct 16, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related quick sort See: https://sampleprograms.io/projects/quick-sort/ labels Oct 16, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 16, 2019
@jrg94 jrg94 changed the title Added quick sort in javascript Added Quick Sort in JavaScript Oct 16, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the requirements. This is currently failing testing.

@@ -0,0 +1,35 @@
const arr = [6, 2, 5, 3, 8, 7, 1, 4]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should come from the user through the command line.

@Gurmeet22
Copy link
Contributor Author

Gurmeet22 commented Oct 18, 2019 via email

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs great, now! 🐤

@jrg94 jrg94 merged commit 7e4ca32 into TheRenegadeCoder:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related quick sort See: https://sampleprograms.io/projects/quick-sort/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Quick Sort in JavaScript
2 participants