-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Quick Sort in JavaScript #1651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check the requirements. This is currently failing testing.
archive/j/javascript/quick-sort.js
Outdated
@@ -0,0 +1,35 @@ | |||
const arr = [6, 2, 5, 3, 8, 7, 1, 4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should come from the user through the command line.
Ok I will change that
…On Fri, Oct 18, 2019, 9:30 PM Jeremy Grifski ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In archive/j/javascript/quick-sort.js
<#1651 (comment)>
:
> @@ -0,0 +1,35 @@
+const arr = [6, 2, 5, 3, 8, 7, 1, 4]
This should come from the user through the command line.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1651?email_source=notifications&email_token=AIKDHKNZ4KRTF6OL52YIMPDQPHMTRA5CNFSM4JBJOGQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIPHZYQ#pullrequestreview-303987938>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKDHKJT3FCTY3SH24XB3MTQPHMTRANCNFSM4JBJOGQQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs great, now! 🐤
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated Quick Sort in Javascript
formatDocumentation
Added/Updated <Sample Program> in <Language> Article
formatTesting
Added/Updated <Language>/<Project> Testing
formatNotes
Feel free to describe what you added or updated.