Added Fibonacci in Nim #1670
Merged
Added Fibonacci in Nim #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrg94
added
enhancement
jrg94
requested changes
Oct 17, 2019
archive/n/nim/fibonacci.nim
Outdated
| # Fibonacci Sample Program in Nim | ||
| import strutils | ||
|
|
||
| echo "Input the number of iterations (n): " |
There was a problem hiding this comment.
For this program, I'd take a peek at the requirements: https://sample-programs.therenegadecoder.com/projects/fibonacci/
We typically don't prompt for input. Instead, we pull it directly off the command line. Does Nim support command line args?
There was a problem hiding this comment.
Yeah once I saw the build failed I started looking into that. There are a number of ways, just trying to figure out an os-agnostic method.
|
Just took a peek at your tests. Everything looks great! At this point, it's an output formatting issue. We print all terms in the sequence in order by index: |
jrg94
reviewed
Oct 17, 2019
archive/n/nim/fibonacci.nim
Outdated
| echo "Usage: please input the count of fibonacci numbers to output" | ||
| quit(1) | ||
| except ValueError: | ||
| echo "invalid input: not a number" |
There was a problem hiding this comment.
We use the same string for both cases. Sorry if that was confusing in the table.
Suggested change
| echo "invalid input: not a number" | |
| echo "Usage: please input the count of fibonacci numbers to output" |
|
Yes - this was the invalid file name that should have been tracked for
removal when it was renamed to hello_world.nim
…On Wed, Oct 16, 2019, 11:50 PM Jeremy Grifski ***@***.***> wrote:
Was hello-world.nim intentionally deleted? Looks like it's going to get
deleted when we merge this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1670?email_source=notifications&email_token=ABWFAEAJF2YDXIRLX2MUUA3QO7VI3A5CNFSM4JBS4G6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBOYNQY#issuecomment-543000259>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWFAEGTWBT2RMGH3WX2V4DQO7VI3ANCNFSM4JBS4G6A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Snippets
Added/Updated <Sample Program> in <Language>format