Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Roman Numeral Conversion in C++ #1730

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Conversation

sailok
Copy link
Contributor

@sailok sailok commented Oct 21, 2019

Added C++ code for Roman to Numeral conversion

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

Added C++ code for Roman to Numeral conversion
@jrg94 jrg94 requested a review from a team October 21, 2019 15:02
@jrg94 jrg94 self-assigned this Oct 21, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related roman numeral See: https://sampleprograms.io/projects/roman-numeral/ labels Oct 21, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 21, 2019
@jrg94 jrg94 changed the title Added Roman to Numeral conversion Added Roman Numeral Conversion in C++ Oct 21, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Any chance you can add this to the local README?

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🍂

@jrg94 jrg94 merged commit ddd9578 into TheRenegadeCoder:master Oct 22, 2019
@sailok
Copy link
Contributor Author

sailok commented Oct 23, 2019

Hi,I have a small doubt, May I know why this PR status is not being updated in Hacktoberfest Website.It is still being shown as Under Review?

@jrg94
Copy link
Member

jrg94 commented Oct 23, 2019

It takes 7 days to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related roman numeral See: https://sampleprograms.io/projects/roman-numeral/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants