Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing grammatical errors in the CODE_OF_CONDUCT.md file. #1734

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

msj2
Copy link
Contributor

@msj2 msj2 commented Oct 21, 2019

Fixing grammatical errors.

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.
Code of Conduct had 4 grammatical issues. These were updated.

Fixing grammatical errors.
@msj2 msj2 changed the title Fixing grammatical errors Fixing grammatical errors in the CODE_OF_CONDUCT.md file. Oct 21, 2019
@stuin
Copy link
Member

stuin commented Oct 21, 2019

I noticed some additional mixups on lines 25 and 39, and 201 has multiple possible awnsers, but otherwise it all looked good to me.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. Thanks for teaching me a few new tricks! I only spotted one error in the corrections.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Show resolved Hide resolved
.github/CONTRIBUTING.md Show resolved Hide resolved
.github/CONTRIBUTING.md Show resolved Hide resolved
@jrg94 jrg94 self-assigned this Oct 22, 2019
@jrg94 jrg94 added the bug Something isn't working label Oct 22, 2019
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@jrg94 jrg94 merged commit b84f83f into TheRenegadeCoder:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Updated grammatical errors in the CODE_OF_CONDUCT.md file Request
3 participants