Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Binary Search in Go #1762

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Added Binary Search in Go #1762

merged 2 commits into from
Oct 24, 2019

Conversation

auroq
Copy link
Contributor

@auroq auroq commented Oct 24, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@auroq auroq added enhancement Any code that improves the repo binary search See: https://sampleprograms.io/projects/binary-search/ labels Oct 24, 2019
@auroq auroq added this to the 500 Code Snippets milestone Oct 24, 2019
@auroq auroq requested a review from jrg94 October 24, 2019 16:41
@auroq
Copy link
Contributor Author

auroq commented Oct 24, 2019

@jrg94, This is currently failing one test as per my comments here:
#1755 (comment)
I can make the changes one way or the other once we decide on that.

@auroq
Copy link
Contributor Author

auroq commented Oct 24, 2019

This should be merged after #1763 as it includes some changes from there in order to fix the tests.

@auroq
Copy link
Contributor Author

auroq commented Oct 24, 2019

@jrg94 this is ready now

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Glad testing worked as expected for the most part.

@jrg94 jrg94 merged commit 8e4ee7f into master Oct 24, 2019
@jrg94 jrg94 deleted the go-binarysearch branch October 24, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary search See: https://sampleprograms.io/projects/binary-search/ enhancement Any code that improves the repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Binary Search in Go
2 participants