Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FizzBuzz in R #1768

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Added FizzBuzz in R #1768

merged 3 commits into from
Nov 5, 2019

Conversation

gabiherman
Copy link
Contributor

@gabiherman gabiherman commented Oct 24, 2019 •
edited

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see [plagiarism][2])

@jrg94 jrg94 requested a review from a team October 25, 2019 14:34
@jrg94 jrg94 self-assigned this Oct 25, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo fizz buzz See: https://sampleprograms.io/projects/fizz-buzz/ hacktoberfest Hacktoberfest related labels Oct 25, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 25, 2019
jrg94
jrg94 requested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm not sure it's executable, however. Any chance you could make a call to your function?

@gabiherman
Copy link
Contributor Author

Yep, will make it executable! Thanks.

@jrg94
Copy link
Member

jrg94 commented Nov 5, 2019

Hey @gabiherman! This is really close. Any update on this?

@jrg94 jrg94 mentioned this pull request Nov 5, 2019
Merged
7 tasks
jrg94
jrg94 approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jrg94 jrg94 merged commit 4928ca8 into TheRenegadeCoder:master Nov 5, 2019
@jrg94 jrg94 mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo fizz buzz See: https://sampleprograms.io/projects/fizz-buzz/ hacktoberfest Hacktoberfest related
Projects
Code Snippets
Archived in project
Milestone
500 Code Snippets
Development

Successfully merging this pull request may close these issues.

Add FizzBuzz in R
2 participants
@gabiherman @jrg94