Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JobSequencing in Java #1778

Merged
merged 5 commits into from
Oct 27, 2019
Merged

Added JobSequencing in Java #1778

merged 5 commits into from
Oct 27, 2019

Conversation

janeliutw
Copy link
Contributor

@janeliutw janeliutw commented Oct 26, 2019 •
edited

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • [ x ] I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 26, 2019 21:36
@jrg94 jrg94 self-assigned this Oct 26, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related job sequencing See: https://sampleprograms.io/projects/job-sequencing/ labels Oct 26, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 26, 2019
jrg94
jrg94 requested changes Oct 26, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just need to update the code to match the description.

archive/j/java/JobSequencing.java Outdated

try {
Scanner scanner = new Scanner(System.in);
System.out.print("Please enter job profits separated by \", \" (e.g., 25, 15, 10, 5):");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of leveraging a Scanner, can you grab the inputs off the command line. That way, we can test it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code to get direct input from the command line. Hopefully it works this time!

jrg94
jrg94 approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This works great.

@jrg94 jrg94 merged commit 90c8aa5 into TheRenegadeCoder:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related job sequencing See: https://sampleprograms.io/projects/job-sequencing/
Projects
Code Snippets
Archived in project
Milestone
500 Code Snippets
Development

Successfully merging this pull request may close these issues.

Add Job Sequencing with Deadlines in Java
2 participants
@janeliutw @jrg94