Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Binary Search #1785

Merged
merged 3 commits into from
Oct 27, 2019
Merged

Added Binary Search #1785

merged 3 commits into from
Oct 27, 2019

Conversation

rayavarapuvikram1
Copy link
Contributor

Please do suggest changes for Binary Search Program.

@jrg94 jrg94 requested a review from a team October 26, 2019 21:51
@jrg94 jrg94 self-assigned this Oct 26, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo binary search See: https://sampleprograms.io/projects/binary-search/ hacktoberfest Hacktoberfest related labels Oct 26, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 26, 2019
jrg94
jrg94 requested changes Oct 26, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check your error string. Looks good otherwise!

archive/p/python/binary_search.py Outdated Show resolved Hide resolved
@rayavarapuvikram1 @jrg94
Update archive/p/python/binary_search.py
8ac9b39 
Co-Authored-By: Jeremy Grifski <jeremy.grifski@gmail.com>
@rayavarapuvikram1
Copy link
Contributor Author

Can it be committed to the master branch now?

jrg94
jrg94 approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@jrg94 jrg94 merged commit 09c32ac into TheRenegadeCoder:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
binary search See: https://sampleprograms.io/projects/binary-search/ enhancement Any code that improves the repo hacktoberfest Hacktoberfest related
Projects
Code Snippets
Archived in project
Milestone
500 Code Snippets
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rayavarapuvikram1 @jrg94