Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quick Sort in Dart #1810

Merged
merged 7 commits into from
Nov 4, 2019
Merged

Added Quick Sort in Dart #1810

merged 7 commits into from
Nov 4, 2019

Conversation

Oxymora
Copy link
Contributor

@Oxymora Oxymora commented Oct 28, 2019

example for recursion in dart and an example of the divide and conquer method with quicksort

@jrg94 jrg94 changed the title quicksort in dart Added Quick Sort in Dart Oct 28, 2019
@jrg94 jrg94 requested a review from a team October 28, 2019 21:13
@jrg94 jrg94 self-assigned this Oct 28, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related quick sort See: https://sampleprograms.io/projects/quick-sort/ labels Oct 28, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 28, 2019
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fails testing. Double check the requirements!

@Oxymora
Copy link
Contributor Author

Oxymora commented Nov 2, 2019

i am a bit confused, why the test are not working. I use the same in_params for my tests on my local machine. I used a similar parser for the input and the same output format like bubble_sort.dart.
So either, there is a problem in my output format or something else is the problem. Still, it would be nice to see what the error is. Just an assertion error doesn't help me.

@jrg94
Copy link
Member

jrg94 commented Nov 2, 2019

You're right! It does work. I think the issue is that we're expecting the scripts to be standalone. You should remove the bubble.sort reference and add in the exitWithError method.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for helping out. ⚡️

@jrg94 jrg94 merged commit db88ae8 into TheRenegadeCoder:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related quick sort See: https://sampleprograms.io/projects/quick-sort/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants