Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash Script Housekeeping #1815

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Bash Script Housekeeping #1815

merged 2 commits into from
Oct 28, 2019

Conversation

daveloyall
Copy link
Contributor

I read your CONTRIBUTING.md. This change does not fit in one of the categories. It's just some housekeeping.

The bash scripts used to look like this:
image

After my change, they look like this:
image

Cheers!

@jrg94 jrg94 changed the title add +x for shell scripts that are missing it. Added +x for shell scripts that are missing it. Oct 28, 2019
@jrg94 jrg94 requested a review from a team October 28, 2019 22:02
@jrg94 jrg94 self-assigned this Oct 28, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related labels Oct 28, 2019
jrg94
jrg94 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Love these kinds of fixes. Thanks.

rename evenodd.sh to even-odd.sh
9c25f90 
Make this file match the `hyphen` naming convention.
@daveloyall
Copy link
Contributor Author

I'm sorry, github automatically brought an additional commit into this. But, it's on a different topic..

Thanks, github. /s

...I don't know how to undo it.

@daveloyall
Copy link
Contributor Author

I guess we could rename this to "housekeeping on bash scripts". :)

@jrg94 jrg94 changed the title Added +x for shell scripts that are missing it. Bash Script Housekeeping Oct 28, 2019
@auroq
Copy link
Contributor

auroq commented Oct 28, 2019

This is one of the things I've been meaning to look at. Thanks for doing this!

@jrg94 jrg94 merged commit 8b41952 into TheRenegadeCoder:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo hacktoberfest Hacktoberfest related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daveloyall @auroq @jrg94