Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added File IO in lua #1836

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Added File IO in lua #1836

merged 3 commits into from
Nov 1, 2019

Conversation

bhaskaaar
Copy link

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jrg94 jrg94 self-assigned this Oct 31, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo file input output See: https://sampleprograms.io/projects/file-input-output/ hacktoberfest Hacktoberfest related labels Oct 31, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 31, 2019
Copy link
Contributor

@auroq auroq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick thing, would you mind naming the file it creates "output.txt"? That way it will work with our tests once we add lua testing.

@jrg94
Copy link
Member

jrg94 commented Nov 1, 2019

Updated it!

@jrg94 jrg94 merged commit 8bada6b into TheRenegadeCoder:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo file input output See: https://sampleprograms.io/projects/file-input-output/ hacktoberfest Hacktoberfest related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants