Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fibonacci in Scheme #1850

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Conversation

lbarros00
Copy link
Contributor

@lbarros00 lbarros00 commented Nov 1, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you make the script runnable? Looks like this is a function definition, but we don't actually execute it with user input.

@jrg94 jrg94 self-assigned this Nov 1, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/ hacktoberfest Hacktoberfest related labels Nov 1, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Nov 1, 2019
@jrg94 jrg94 changed the title add Fibonacci in Scheme Added Fibonacci in Scheme Nov 1, 2019
@lbarros00
Copy link
Contributor Author

lbarros00 commented Nov 2, 2019

Okay, I've made the requested update :)

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Only thing missing is the error message for bad input. See the testing table here: https://sample-programs.therenegadecoder.com/projects/fibonacci/

@lbarros00
Copy link
Contributor Author

@jrg94 okay, I have added the error message for bad input :)

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔑

@jrg94 jrg94 merged commit ee23e2c into TheRenegadeCoder:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/ hacktoberfest Hacktoberfest related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Fibonacci in Scheme
2 participants