Updated GameOfLife in Java #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setDefaultCloseOperation will close the game window when the X button is clicked
jrg94
requested changes
Oct 1, 2020
There was a problem hiding this comment.
All this is great! You raise a great point about 1 which we never considered in the original documentation: https://sample-programs.therenegadecoder.com/projects/prime-number/
Unfortunately, we'll have to update all of our prime implementations because testing currently assumes 1 is composite. Perhaps you can pull that portion out into a separate pull request. That way we can incorporate your GameOfLife change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDefaultCloseOperation will close the game window when the X button is clicked
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated <Sample Program> in <Language>formatTesting
Added/Updated <Language>/<Project> TestingformatNotes
Feel free to describe what you added or updated.