Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Linear Search in JavaScript #1916

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Added Linear Search in JavaScript #1916

merged 2 commits into from
Oct 1, 2020

Conversation

NameerWaqas
Copy link
Contributor

@NameerWaqas NameerWaqas commented Oct 1, 2020 •
edited

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
  • I added the sample program name to the README
  • I added fun facts (i.e. debut, developer, typing, etc.)
  • I added reference link(s) to the README
  • I added solution citations when necessary (see plagiarism)

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 1, 2020 18:37
@jrg94 jrg94 self-assigned this Oct 1, 2020
@jrg94 jrg94 added the enhancement Any code that improves the repo label Oct 1, 2020
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 1, 2020
@jrg94 jrg94 added the linear search See: https://sampleprograms.io/projects/linear-search/ label Oct 1, 2020
jrg94
jrg94 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't believe we've tested this yet, so we may have to circle back once that's implemented.

@jrg94 jrg94 changed the title Added Linear Search algorithm in JS with updated README.md. Added Linear Search algorithm in JavaScript Oct 1, 2020
@jrg94 jrg94 changed the title Added Linear Search algorithm in JavaScript Added Linear Search in JavaScript Oct 1, 2020
@jrg94 jrg94 merged commit 827d896 into TheRenegadeCoder:master Oct 1, 2020
@NameerWaqas
Copy link
Contributor Author

Thank you so much @jrg94 for merging my PR.

@NameerWaqas
Copy link
Contributor Author

@jrg94 I also have added more algorithms which I have tested personally, working fine for for me but here in PR it's showing a red cross. Can you please tell me the issue so I can correct, I am a newbie at opensource contributions.
PR #2024
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo linear search See: https://sampleprograms.io/projects/linear-search/
Projects
Code Snippets
Archived in project
Milestone
500 Code Snippets
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NameerWaqas @jrg94