Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Factorial in SCALA #2099

Merged
merged 5 commits into from
Oct 5, 2020
Merged

Added Factorial in SCALA #2099

merged 5 commits into from
Oct 5, 2020

Conversation

uditanshh
Copy link
Contributor

@uditanshh uditanshh commented Oct 3, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just make sure the program pulls from the command line.

@uditanshh
Copy link
Contributor Author

Hey @jrg94, thanks for suggesting changes. I am new to scala. If you can just tell me what do I do to make sure the program gets merged, it'll be really great.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this helps!

archive/c/c-plus-plus/linear-search.CPP Outdated Show resolved Hide resolved
archive/s/scala/factorial.scala Outdated Show resolved Hide resolved
@jrg94 jrg94 self-assigned this Oct 4, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/ labels Oct 4, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 4, 2020
@jrg94 jrg94 changed the title Added Factorial Program In SCALA Added Factorial in SCALA Oct 4, 2020
@uditanshh
Copy link
Contributor Author

Hey @jrg94, I have updated the code. Please go through it and let me know if you want any changes.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! We may revisit this when we do some testing. There are deprecation warnings, and the formatting is a bit messy.

@jrg94 jrg94 merged commit 6ad6726 into TheRenegadeCoder:master Oct 5, 2020
@uditanshh
Copy link
Contributor Author

Hey @jrg94, If you can add the hacktoberfest-accepted label to this pull request, it'll be really great.

@uditanshh uditanshh deleted the uditansh-commits branch October 5, 2020 15:15
@jrg94
Copy link
Member

jrg94 commented Oct 5, 2020

Do you have any documentation on that label? I haven't seen anything about it on the official site.

@jrg94
Copy link
Member

jrg94 commented Oct 5, 2020

@jrg94
Copy link
Member

jrg94 commented Oct 5, 2020

It's sort of a pain to label all accepted pull requests. Based on the article above, merging and accepting should be enough.

@uditanshh
Copy link
Contributor Author

uditanshh commented Oct 5, 2020 via email

@jrg94
Copy link
Member

jrg94 commented Oct 5, 2020

Hey @uditpatel2526! If you enjoyed contributing to this project and would like to make sure that it continues to be maintained, we can always use your support at The Renegade Coder. Here are some ways you can help out:

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Factorial in Scala
2 participants